Commit Graph

1022 Commits

Author SHA1 Message Date
Christoph Strobl
e280a23550 DATAREDIS-269 - Add support for 'CLIENT SETNAME'.
Setting client name is possible for 'jedis', 'lettuce' and 'srp'.
Using 'jredis' throws 'UnspupportedOperationException'.

Original Pull Request: #54
2014-03-26 11:44:01 +01:00
Christoph Strobl
6a6d03eb4c DATAREDIS-267 - Add support for 'CLIENT KILL'.
Killing a client connection can be done via 'RedisConnection' and 'RedisOperations' using 'jedis', 'lettuce' and 'srp'.

We use dedicated parameters for host and port building up the redis format (host:port) for connection identification.

Original Pull Request: #56
2014-03-26 11:33:35 +01:00
Christoph Strobl
1c47330ec9 DATAREDIS-286 - Avoid overflow in JedisConnection#expire / #pexpire.
Added unit test to verify that 'time()' is called prior to 'pExpireAt'.
2014-03-24 11:29:53 +01:00
Thomas Darimont
59582f1910 DATAREDIS-286 - Avoid overflow in JedisConnection#expire / #pexpire.
Workaround Jedis issue https://github.com/xetorthio/jedis/pull/575.
We now delegate calls to expire(...) to pExpireAt(...) in case the seconds parameter is > than Integer.MAX_VALUE.
We query the server time to compute the new expiration date.

Original pull request: #52.
2014-03-24 11:28:40 +01:00
Christoph Strobl
408b52a449 DATAREDIS-261 - Upgrade to commons-pool2.
'JRedisPool' and 'DefaultLettucePool' have been migrated to 'commons-pool2'.

'PoolConfig' has been deprecated, and will be removed in '1.4', as all required operations are available via 'GenericObjectPoolConfig'.

Along the way a minor bug within 'LettuceConnection' has been resolved, which prevented 'RedisAsyncConnections' from being properly closed/returned to pool.

Original Pull Request: #50
2014-03-20 13:07:05 +01:00
Christoph Strobl
d116d3825a DATAREDIS-184 - Add support for 'SAVE/NOSAVE' to shutdown.
Created and added 'ShutdownOptions' to 'RedisServerCommands'. The full implementation is available for 'lettuce' and 'srp'.

When using 'jedis' the command is emulated using lua script via 'eval'.

For 'jredis' the method is not available and will throw 'UnsupportedOperationException'.

Original Pull Request: #47
2014-03-20 12:49:41 +01:00
Christoph Strobl
4b2ccbecb9 DATAREDIS-271 - Add support for 'pSetEx'.
Support for 'pSetEx' has been added for 'jedis' & 'srp'.
For 'lettuce' the command is emulated using 'eval'.

There is no support for 'pSetEx' when using 'jredis'.

'DefaultValueOperations.set' used with 'TimeUnit.MILLISECONDS' will fallback to 'setEx' in case 'pSetEx' is not supported by the driver in use.

Original pull request: #46.
2014-03-20 12:36:09 +01:00
Christoph Strobl
a3ac8d0899 DATAREDIS-285 - LettuceConnection.execute should fully read response.
'LettuceConnection' used 'ByteArrayOutput' as default for execute which did not fully read all values that might be included in the response.

To overcome this issue 'TypeHints' have been added which map a given 'CommandType' to the most recent 'CommandOutput'.  As not all commands could be mapped that way due to the result depending on input parameters in some cases, it might be required to manually provide the type hint when calling execute.

Additional tests have been added to assert 'execute' works properly for 'jedis', 'jredis' and 'srp'.

Original Pull Request: #49
2014-03-19 11:26:19 +01:00
Thomas Darimont
9cf484d25a DATAREDIS-283 - RedisCacheManager.loadCaches overrides already defined cache names in afterPropertiesSet().
We now retain the potentially already configured caches during the initialisation of the RedisCacheManager bean. Previously we discarded the already configured caches which was an undesired side-effect.

Original pull request: #45.
2014-03-13 06:33:37 +01:00
Thomas Darimont
ec2a760dd6 DATAREDIS-275 - Rename RedisServerCommands.bgWriteAof to bgReWriteAof.
Renamed method and placed @Deprecated delegate-Methods in order to avoid breaking clients.

Original pull request: #44.
2014-03-10 09:00:01 +01:00
Spring Buildmaster
86205e3b67 DATAREDIS-256 - Prepare next development iteration. 2014-03-03 05:48:34 -08:00
Thomas Darimont
0f8c68c251 DATAREDIS-282 - PubSubResubscribeTests should use jedis without pool.
Disabled jedis pooling in PubSubResubscribeTests since all the other tests also don't use a pool.

Original pull request #43.
2014-03-03 14:36:06 +01:00
Christoph Strobl
1881e626d0 DATAREDIS-256 - Prepare 1.2 GA Release.
Update readme and changelog.

Original Pull Request: #42
2014-03-03 10:31:09 +01:00
Christoph Strobl
bc31655417 DATAREDIS-279 - Update documentation
Corrected typos and added copyright information.
Updated sync nature for subscriptions using RMLC.
Added RedisTemplate command reference.
Added include-fallback to appendix-schema reference.

Original pull request: #41.
2014-02-27 13:54:14 +01:00
Spring Buildmaster
c6c38180f3 DATAREDIS-262 - Prepare next development iteration. 2014-02-19 03:36:35 -08:00
Spring Buildmaster
84698127bf DATAREDIS-262 - Release version 1.2.0.RC1. 2014-02-19 03:36:29 -08:00
Christoph Strobl
9215f6c139 DATAREDIS-262 - Prepare 1.2.0.RC1 release.
Update changelog, notice, readme.
Renamed apache-license to license.
2014-02-19 10:40:32 +01:00
Christoph Strobl
c2f2febb81 DATAREDIS-259 - Upgrade Spring Framework to latest 3.2.x.
Upgraded to Spring 3.2.8.RELEASE.

Original pull request: #39
2014-02-19 10:08:56 +01:00
Christoph Strobl
3a49fd14e5 DATAREDIS-266 - Update Documentation.
Updated links in javadoc. Added API javadoc with references to the redis commands. Updated reference manual. Updated Readme and contributing guide.
Updated (SCM and developer information in) gradle build and template.mf bundle manifest.

Original pull request: #38
2014-02-18 10:35:30 +01:00
Christoph Strobl
e003ef6ca3 DATAREDIS-206 - Add support for TIME operation.
Enhanced RedisServerCommands to reflect time operation and added empty implementation to recent RedisConnection abstractions.
Added implementation of time() for Srp, Jedis, Lettuce (emulated via eval).
Added UnsupportedOperation of time() JRedis since it doesn't support time command or sending scripts or sending raw commands via the underlying connection.
Added implementation for DefaultStringRedisConnection to delegate time() operation to native connection.
Added integration test to abstract base class. Ignored the test for those connections not supporting time command.

Original pull request: #34
2014-02-18 10:14:46 +01:00
Thomas Darimont
b4cc33a24c DATAREDIS-241 - Updated jedis to version 2.4.1.
Original pull request: #37
2014-02-18 10:10:08 +01:00
Christoph Strobl
82578066e8 DATAREDIS-246 - RedisCacheManager.getCache() does not match the logical of CompositeCacheManager.
By default RedisCacheManager lazily initializes RedisCaches when requested. To put it into static mode a defined set of cache names has to be passed to the CacheManager.

We changed the implementation so it  makes use of AbstractTransactionalCache introduced in Spring 3.2 which properly registers caches. Additionally the loadRemoteCachesOnStartup switch allows to retrieve and initialize existing caches by loading keys form redis server.

Further on RedisCacheManager can be set in transaction aware mode so that values are only put into cache after successful commit of surrounding transaction.

Original pull request: #33
2014-02-17 13:39:18 +01:00
Thomas Darimont
11f94b0810 DATAREDIS-265 - Update Java source and target compatibility to Java 6.
Updated build.gradle accordingly.

Original pull request: #36
2014-02-12 10:33:59 +01:00
Thomas Darimont
3750dbba31 DATAREDIS-264 - Update gradle version.
Updated gradle version to most recent one 1.11.

Original pull request: #35
2014-02-12 10:25:50 +01:00
Thomas Darimont
9a416fbcf7 DATAREDIS-259 - Upgrade to Spring 3.2.7.RELEASE.
Original pull request: #32
2014-02-06 18:33:58 +01:00
Christoph Strobl
5466a70034 DATAREDIS-260 - Upgrade to jedis 2.3.1.
Jedis upgraded from commons-pool to commons-pool2. Required changes have been introduced. Currently there are both commons-pool and commons-pool2 in class-path which is no problem as those dependencies are optional.

Original pull request: #31
2014-02-06 18:26:05 +01:00
Christoph Strobl
dea6403c24 DATAREDIS-166 - Corrupted i/o streams subscribing to both patterns and channels.
The issue has already been fixed in DATAREDIS-242 (see PR: #25), which now allows to reenable the previously failing test.
Additionally the tests now run against all supported client libraries except JRedis which does not support 'publish'.

Original pull request: #30
2014-02-06 09:54:24 +01:00
Christoph Strobl
d4c5990831 DATAREDIS-170 - Cancel SubscriptionTask can leave connection open.
RedisMessageListenerContainer did not properly close connections if the subscription was canceled immediately after staring the container. Since DARAREDIS-242 the container waits for the subscription to complete and therefor no more connections remain open.

Additionally added missing parameters to run tests with JRedis.

Original pull request: #29
2014-02-05 18:22:27 +01:00
Thomas Darimont
eaf249af90 DATAREDIS-188 - Infinite loop renaming a non-existent Collection when using Lettuce.
We run into an infinite loop in org.springframework.data.redis.support.collections.CollectionUtils.rename(K, K, RedisOperations<K, ?>) if no value was associated with the key which leads to operations.hasKey(...) always returning false which prevents the actual renaming. RedisCollections will only send rename command if values are present as empty collections cannot be stored and therefor cannot be renamed.

Original pull request: #28
2014-02-05 09:50:32 +01:00
Christoph Strobl
e42e803603 DATAREDIS-254 - Clean up codebase to match spring-data conventions
Remove orphaned test context files.
Update documentation to reflect new version dependencies.
2014-01-28 10:55:12 +01:00
Christoph Strobl
e0524379d6 DATAREDIS-254 - Clean up codebase to match spring-data conventions
format code with spring data formatter
2014-01-28 10:55:00 +01:00
Andy Wilkinson
b99992a8f5 DATAREDIS-257 - Shutdown the client when DefaultLettucePool is destroyed.
DefaultLettucePool manages a RedisClient instance that's created
when afterPropertiesSet is called. The client was not being shutdown
as part of the pool's destroy() processing leading to a resource leak.
On OS X this would manifest itself as a growing number of kqueue file
descriptors being consumed eventually leading to a failure when
something tries to get a file descriptor and is unable to do so.

This commit updates destroy() to call the client's shutdown() method.

Original pull request: #26
2014-01-23 09:54:40 +01:00
Thomas Darimont
b5adde7430 DATAREDIS-242 - Listener Container start() Returns Before Container is Really Started.
We now wait for the subscription to be present in the connection in case of async connections by periodically checking whether the subscription is available in 100ms intervals. The max time to wait for the async subscription can be configured and is set to 2 seconds by default.

Moved SpinBarrier and TestCondition from test packages as static inner classes into RedisMessageListenerContainer. Included ConnectionUtils from tests into official API.
2014-01-20 14:23:18 +01:00
Thomas Darimont
c6d2d7f9c9 DATAREDIS-241 - Add a Jackson2 based RedisSerializer.
Introduced Jackson2JsonRedisSerializer and added optional dependency for Jackson2 core/databind (fasterxml) library.
Added additional parameterised test cases. Needed to increase the max active connections limit for the connection pools used in RedisMapTests.
2014-01-17 12:04:05 +01:00
Jennifer Hickey
e1b421f942 DATAREDIS-237 - Upgrade to Jedis 2.2.1.
Update to Jedis 2.2.1 and Implement newly supported Operations.
Handle removed BinaryTransaction class.
Handle some Jedis return types changed from String to bytes.
Handle some Jedis arg types changed from int to long by removing casting.
Remove ignored tests for issues fixed in Jedis 2.2.1
Throw UnsupportedOpException on multi-arg bitOp NOT
Ensure consistent results across all drivers when bitOp is called with NOT and more than one arg.
2014-01-16 14:34:02 +01:00
Thomas Darimont
2870df0cdc DATAREDIS-251 - Fix tests to work against Redis 2.8.x.
Since Redis 2.8.x keyOps#getExpire() returns -2 for empty collections (RedisList/RedisSet/RedisMap). 
We're now adding a dummy entry to keep the test version agnostic. Previously getExpire() returned -1.
We also have to set the RedisAtomic(Integer|Long) to a value other than 0 to get  the value stored appropriately.

For reference see the discussion in http://redis.io/commands/ttl
2014-01-16 13:43:36 +01:00
Thomas Darimont
168713aae1 DATAREDIS-253 - Avoid usage of deprecated API.
Changed usage of TypeFactory to the recommended API.
2014-01-16 10:39:52 +01:00
Thomas Darimont
b5137e6dd4 DATAREDIS-245 - Prevent Excessive Thread creation in tests.
Rewritten testPubSubWithPatterns in order to make it pass reliably by keeping the original test semantics.
2014-01-16 09:31:17 +01:00
Thomas Darimont
2af23692f3 DATAREDIS-251 - Fix tests to work against Redis 2.8.x.
Since Redis 2.8.x keyOps#getExpire() now returns -2 for empty collections (RedisList/RedisSet/RedisMap) we add a dummy entry to keep the test version agnostic. Previously getExpire() returned -1.

For reference see the discussion in http://redis.io/commands/ttl
2014-01-15 19:36:22 +01:00
Thomas Darimont
2c9e34330b DATAREDIS-245 - Prevent Excessive Thread creation in tests.
Rewritten testPubSubWithNamedChannels in order to make it pass reliably by keeping the original test semantics.
2014-01-15 19:22:25 +01:00
Thomas Darimont
47ef20fec5 DATAREDIS-250 - Upgrade to latest Spring Framework 3.2.x release.
Updated dependencies for slf4j, junit and mockito to match the Spring Framework dependencies.
2014-01-15 12:43:19 +01:00
Thomas Darimont
3d008125e7 DATAREDIS-249 - Improve logging for tests in Gradle build.
Changed exceptionFormat to full in order to get more detail StackTrace information for exceptions during test execution.
2014-01-15 11:17:04 +01:00
Thomas Darimont
14bf8f13b1 DATAREDIS-243 - Ensure compatibility with Spring Framework 4.0.
Updated dependency of XStream since Spring framework 4.0 requires a newer version.
Spring 4 added another method to get cached object to the Cache interface. The method has been added to RedisCache in order to provide compatibility, while calling get internally and casting values to required type.
2014-01-15 10:45:37 +01:00
Thomas Darimont
44584b235d DATAREDIS-245 - Prevent Excessive Thread creation in tests.
Due to some missing cleanup procedures excessive thread creation lead to JVM crashes during a full test run on some machines.
Improved test harness in order to properly shutdown unused threads.

Added idea artefacts to .gitignore.
2014-01-15 10:38:32 +01:00
Thomas Darimont
b0c0d23e1f DATAREDIS-248 - Fix generics in DecoratingStringHashMapper to be Java 8 compatible.
Original pull request #13.
2014-01-15 10:38:17 +01:00
Thomas Darimont
e21c81c746 DATAREDIS-247 - locale independent test execution.
Original pull request #17.
2014-01-13 17:24:11 +01:00
Thomas Darimont
d6b2198d3c Updated README.md
Updated dev team information.
Updated external site links (redis.io).
Updated project version information to latest GA (1.1.0.RELEASE) and latest BUILD-SNAPSHOT 1.2.0.BUILD-SNAPSHOT.
2014-01-10 18:24:08 +01:00
Oliver Gierke
d935ed4ed8 Prepare master branch for 1.2.0 development. 2013-12-04 15:59:57 +01:00
Jennifer Hickey
1fba5ea751 Merge remote-tracking branch 'origin/1.1.0.RELEASE'
Conflicts:
	gradle.properties
2013-09-09 10:26:50 -04:00
Spring Buildmaster
7e55dbe307 [artifactory-release] Next development version 2013-09-09 06:54:41 -07:00