Spring/spring-data-relational
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improved error message on missing back reference.

Browse Source 
Closes #833
Original pull request 1384
This commit is contained in:
Viktor Ardelean
2022-11-02 15:38:41 +02:00
committed by Jens Schauder
parent d0a82236c6
commit 09f9da5128
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/SqlGenerator.java
View File

@@ -260,7 +260,10 @@ class SqlGenerator {
Condition condition = null;
for (SqlIdentifier backReferenceColumn : parentIdentifier.toMap().keySet()) {
if (SqlIdentifier.EMPTY.equals(backReferenceColumn)){
throw new UnsupportedOperationException(
"An empty SqlIdentifier can't be used in condition. Make sure that all composite primary keys are defined in the query.");
}
Condition newCondition = table.column(backReferenceColumn).isEqualTo(getBindMarker(backReferenceColumn));
condition = condition == null ? newCondition : condition.and(newCondition);
}

11
spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/SqlGeneratorUnitTests.java
View File

@@ -443,6 +443,17 @@ class SqlGeneratorUnitTests {
}
@Test // DATAJDBC-613
void findAllByPropertyWithEmptyBackrefColumn() {
assertThatThrownBy(() -> {
sqlGenerator.getFindAllByProperty(Identifier.of(EMPTY, 0, Object.class),
unquoted("key-column"),
false);
}).isInstanceOf(UnsupportedOperationException.class)
.hasMessageContaining("An empty SqlIdentifier can't be used in condition. Make sure that all composite primary keys are defined in the query.");
}
@Test // DATAJDBC-219
void updateWithVersion() {