DATAJDBC-510 - Polishing.

Minor formatting and removal of a deprecated constructor since this is for a major release anyway.

Original pull request: #192.

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/BasicJdbcConverter.java

@@ -96,22 +96,6 @@ public class BasicJdbcConverter extends BasicRelationalConverter implements Jdbc
 		this.identifierProcessing = IdentifierProcessing.ANSI;
 	}
 
-	/**
-	 * Creates a new {@link BasicRelationalConverter} given {@link MappingContext}.
-	 *
-	 * @param context must not be {@literal null}.
-	 * @param relationResolver used to fetch additional relations from the database. Must not be {@literal null}.
-	 * @param typeFactory must not be {@literal null}
-	 * @since 1.1
-	 */
-	@Deprecated
-	public BasicJdbcConverter(
-			MappingContext<? extends RelationalPersistentEntity<?>, ? extends RelationalPersistentProperty> context,
-			RelationResolver relationResolver, CustomConversions conversions, JdbcTypeFactory typeFactory) {
-
-		this(context, relationResolver, conversions, typeFactory, IdentifierProcessing.ANSI);
-	}
-
 	/**
 	 * Creates a new {@link BasicRelationalConverter} given {@link MappingContext}.
 	 *

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/config/JdbcConfiguration.java

@@ -81,6 +81,7 @@ public class JdbcConfiguration {
 	@Bean
 	public RelationalConverter relationalConverter(RelationalMappingContext mappingContext,
 			@Lazy RelationResolver relationalResolver, Dialect dialect) {
+
 		return new BasicJdbcConverter(mappingContext, relationalResolver, jdbcCustomConversions(),
 				JdbcTypeFactory.unsupported(), dialect.getIdentifierProcessing());
 	}

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/DefaultDataAccessStrategyUnitTests.java

@@ -117,6 +117,7 @@ public class DefaultDataAccessStrategyUnitTests {
 		DelegatingDataAccessStrategy relationResolver = new DelegatingDataAccessStrategy();
 
 		Dialect dialect = HsqlDbDialect.INSTANCE;
+
 		JdbcConverter converter = new BasicJdbcConverter(context, relationResolver,
 				new JdbcCustomConversions(Arrays.asList(BooleanToStringConverter.INSTANCE, StringToBooleanConverter.INSTANCE)),
 				new DefaultJdbcTypeFactory(jdbcOperations), dialect.getIdentifierProcessing());