Spring/spring-data-relational
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAJDBC-262 - Update statements no longer set the id column.

Browse Source
This commit is contained in:
Jens Schauder
2018-09-21 13:55:43 +02:00
committed by Greg Turnquist
parent 0816f4182e
commit 3d67ad08ed
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/java/org/springframework/data/jdbc/core/SqlGenerator.java
View File

@@ -284,8 +284,9 @@ class SqlGenerator {
String updateTemplate = "UPDATE %s SET %s WHERE %s = :%s";
String setClause = columnNames.stream()//
.map(n -> String.format("%s = :%s", n, n))//
String setClause = columnNames.stream() //
.filter(s -> !s.equals(entity.getIdColumn())) //
.map(n -> String.format("%s = :%s", n, n)) //
.collect(Collectors.joining(", "));
return String.format(updateTemplate, entity.getTableName(), setClause, entity.getIdColumn(), entity.getIdColumn());

11
src/test/java/org/springframework/data/jdbc/core/SqlGeneratorUnitTests.java
View File

@@ -199,6 +199,17 @@ public class SqlGeneratorUnitTests {
"FROM");
}
@Test // DATAJDBC-262
public void update() {
assertThat(sqlGenerator.getUpdate()).containsSequence( //
"UPDATE", //
"dummy_entity", //
"SET", //
"WHERE", //
"x_id = :x_id");
}
private PersistentPropertyPath<RelationalPersistentProperty> getPath(String path, Class<?> base) {
return PersistentPropertyPathTestUtils.getPath(context, path, base);
}