Spring/spring-data-relational
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing.

Browse Source 
Fixes copyright dates of new files to the current year.
Fixes the issue reference to use the GitHub notation.
Adds an additional test to ensure that the `ConstantConditionVisitor` doesn't need a predicate.

Original pull request #978
This commit is contained in:
Jens Schauder
2021-05-17 14:59:13 +02:00
parent 5b5a7cddae
commit ec49ba1d3e
3 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/ConstantCondition.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2019-2021 the original author or authors.
* Copyright 2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
package org.springframework.data.relational.core.sql;
/**
* {@link Condition} representing fixed sql statement
* {@link Condition} representing fixed sql predicate.
*
* @author Daniele Canteri
* @since 2.3

2
spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/render/ConstantConditionVisitor.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2019-2021 the original author or authors.
* Copyright 2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.

13
spring-data-relational/src/test/java/org/springframework/data/relational/core/sql/render/ConditionRendererUnitTests.java
View File

@@ -22,6 +22,7 @@ import org.junit.jupiter.api.Test;
import org.springframework.data.relational.core.sql.Column;
import org.springframework.data.relational.core.sql.Conditions;
import org.springframework.data.relational.core.sql.Functions;
import org.springframework.data.relational.core.sql.SQL;
import org.springframework.data.relational.core.sql.StatementBuilder;
import org.springframework.data.relational.core.sql.Table;
@@ -232,7 +233,7 @@ public class ConditionRendererUnitTests {
assertThat(sql).endsWith("WHERE my_table.left NOT IN (my_table.right)");
}
@Test // DATAJDBC-907
@Test // #907
public void shouldRenderJust() {
String sql = SqlRenderer.toString(StatementBuilder.select(left).from(table)
@@ -241,4 +242,14 @@ public class ConditionRendererUnitTests {
assertThat(sql).endsWith("WHERE sql");
}
@Test // #907
public void shouldRenderMultipleJust() {
String sql = SqlRenderer.toString(StatementBuilder.select(left).from(table)
.where( Conditions.just("sql1").and(Conditions.just("sql2")))
.build());
assertThat(sql).endsWith("WHERE sql1 AND sql2");
}
}