Commit Graph

173 Commits

Author SHA1 Message Date
Mark Paluch
eeeb188117 DATAJDBC-560 - Fix Criteria mapping when composing a group from top-level criteria.
Using Criteria.from(…) with multiple Criteria objects now uses properly AND combination along with group nesting to render a correct criteria. Previously, the INITIAL combinator in groups caused a mapping exception.
2020-06-09 15:31:14 +02:00
Mark Paluch
81aba29fda DATAJDBC-546 - Skip property population if entity can be constructed entirely using a full constructor. 2020-05-28 13:54:30 +02:00
Mark Paluch
24ce2a9ba4 DATAJDBC-547 - Polishing.
Add scripts for DB2 after rebase.

Original pull request: #221.
2020-05-27 13:11:55 +02:00
Jens Schauder
d3e6db2cce DATAJDBC-547 - Fixes lock statement for fully qualified table names in PostgreSQL.
Original pull request: #221.
2020-05-27 10:01:39 +02:00
Jens Schauder
4ee9eb8df5 DATAJDBC-544 - Removes all Lombok from production code. 2020-05-20 15:44:03 +02:00
Jens Schauder
dedaf34614 DATAJDBC-545 - Fix support of setting properties via constructor. 2020-05-19 14:46:39 +02:00
Jens Schauder
8e63084162 DATAJDBC-412 - Polishing.
Added an integration test because you never can tell with databases.
2020-05-15 17:04:33 +02:00
Christoph Strobl
6f2bb59ceb DATAJDBC-412 - Support custom single value types in id.
Custom value types like outlined below can now server as id property

public class IdValue {
	String id;
}

public class DomainType {

	@Id
	IdValue id;
	String value;

	// ...
}
2020-05-15 15:30:41 +02:00
Mark Paluch
fc74fa9975 DATAJDBC-542 - Polishing.
Initialize map with capacity. Fix generics.

Original pull request: #218.
2020-05-14 10:42:12 +02:00
Jens Schauder
30a6fb5654 DATAJDBC-542 - Fixes access to Identifier parts by String.
Enabled access to identifier parts by String arguments in order to make usage with MyBatis feasable.
Properly pass identifier information to MyBatis for insert statements.

Original pull request: #218.
2020-05-14 10:42:01 +02:00
Jens Schauder
3c9290483a DATAJDBC-538 - Fixes lock acquisition for DB2.
The DB2 driver requires one to access the `ResultSet` resulting from a SELECT FOR UPDATE.

See also:
* https://github.com/schauder/db2-locks
* https://stackoverflow.com/questions/61681095/how-to-obtain-a-lock-in-db2-with-select-for-update-without-transferring-data

Original pull request: #216.
2020-05-11 14:32:11 +02:00
Jens Schauder
c3fb6d0d51 DATAJDBC-534 - Adds integration test for count projection.
Original pull request: #215.
2020-05-07 08:42:04 +02:00
mhyeon-lee
bc6c88f055 DATAJDBC-534 - Derived Query support for count projection.
Original pull request: #215.
2020-05-07 08:39:22 +02:00
Jens Schauder
aa05b792c3 DATAJDBC-493 - Polishing.
Using `execute` instead of `query` since we are not interested in the results.
Refactoring of the concurrency tests.
Make the concurrency tests run with all databases.
Added support for DB2.
Moved AnsiDialect to the main sources so it can be referenced in other Dialects.

Original pull request: #196.
2020-05-06 16:18:04 +02:00
mhyeon-lee
04c29f4004 DATAJDBC-493 - Avoids deadlocks by acquiring lock on aggregate root table.
Introduces infrastructure to obtain locks and uses them to acquire locks on the table of the aggregate root before deleting references.
Without this lock deletes access non root entities before the aggregate root, which is the opposite order of updates and thus may cause deadlocks.

Original pull request: #196.
2020-05-06 16:18:04 +02:00
Mark Paluch
fa8b95c5f3 DATAJDBC-257 - Polishing.
Move container initialization from static initializer into createDataSource() to not trigger container start when loading the class.
Add TestExecutionListener to ignore tests if the license for a container was not accepted. Add Awaitility to delay test execution until the database is ready so we avoid strange failures due to a delayed container startup.

Fix generics, since tags, author tags. Reformat code.

Original pull request: #213.
2020-05-06 15:54:41 +02:00
Jens Schauder
4bf2b8d0a8 DATAJDBC-257 - Adds DB2 support.
Db2Dialect added in order to support DB2.
Added test configuration files.
Adapted some tests to make them properly work with DB2
QueryAnnotationIntegrationTests converted into an Hsqldb only test since it is next to impossible to make it work across databases since it heavily depends on database and driver specifics.

Removed license acceptance file from the repository in order to not accept a license in the name of someone forking the repository.
For the CI build an appropriate file gets created on the fly.

Original pull request: #213.
2020-05-06 15:49:07 +02:00
Mark Paluch
b0d37bda8a DATAJDBC-529 - Polishing.
Rearrange imports.

Original pull request: #212.
2020-05-05 13:48:53 +02:00
Jens Schauder
370ee4464e DATAJDBC-529 - Use specialized ResultSetExtractor for exists queries.
Exists queries do not look at the value returned in the ResultSet but just check if there is a row.

Original pull request: #212.
2020-05-05 13:45:19 +02:00
Jens Schauder
ac88f1d4f9 DATAJDBC-530 - Polishing.
Original pull request: #210.
2020-05-04 09:19:35 +02:00
mhyeon-lee
f9bc40cc46 DATAJDBC-530 - The sorting property set as the property name.
Original pull request: #210.
2020-05-04 09:17:18 +02:00
Jens Schauder
6420205eed DATAJDBC-524 - Fixed dependency cycles triggered by DATAJDBC-318.
Moved Identifier and IdentifierBuilder to ...jdbc.core.convert.
Moved RelationaAuditingCallback to ..mapping.event.

Improved DependencyTests to properly consider "relational" a main module.
2020-04-28 11:09:52 +02:00
Jens Schauder
d80614b4d8 DATAJDBC-318 - Fixed the generation of the select list.
The select list must include columns for 1:1 relationships.

The implementation is copied from SqlGenerator and will be unified in the near future.

Original pull request: #209.
2020-04-28 09:23:52 +02:00
Mark Paluch
aadbb667ed DATAJDBC-318 - Extend query method validation.
We now reject criteria predicates for collections, maps and references. The select list selects all columns until DATAJDBC-523 is solved.

Original pull request: #209.
2020-04-28 09:23:52 +02:00
Jens Schauder
fd98e16038 DATAJDBC-318 - Adding a failing test.
Added failing tests for entities with references.

Code deduplication.
Documentation wording.
Formatting.

Original pull request: #209.
2020-04-28 09:23:52 +02:00
Mark Paluch
999bf29321 DATAJDBC-318 - Initial support for query derivation.
Move JdbcRepositoryQuery into repository.query package. Split JdbcRepositoryQuery into AbstractJdbcQuery and StringBasedJdbcQuery.
Add QueryMapper for mapping of Criteria.
Initial support for query derivation.

Emit events and issue entity callbacks only for default RowMapper.
Custom RowMapper/ResultSetExtractor are in full control of the mapping and can issue events/callbacks themselves.

Update reference documentation.

Original pull request: #209.
2020-04-28 09:23:52 +02:00
Jens Schauder
2f3f00bd71 DATAJDBC-318 - Adapting DependencyTests.
Without this change we see cyclic dependencies between modules (i.e. subpackages).
The following subpackages had a cycle:

repository.query and repository.query.parser

PartTreeJdbcQuery and JdbcQueryCreator(repository.query from jdbc) depend on PartTree (repository.query.parser)

AbstractQueryCreator (repository.query.parser) depends on ParameterAccessor (repository.query from commons)

This change changes the definition of a module, bundling all the modules above into one module (repository).

Alternative changes that should fix the problem:
1. Move ParameterAccessor to a different (probably new package)
2. Move AbstractQueryCreator to a different (probably new package)
3. org.springframework.data.jdbc.repository.query to e.g. org.springframework.data.jdbc.repository.query.jdbc

Original pull request: #209.
2020-04-28 09:23:52 +02:00
Jens Schauder
c8cbdc5ea0 DATAJDBC-507 - Polishing.
Reduced code duplication.
Fixed Lombok related warnings.

Original pull request: #208.
2020-04-20 12:42:40 +02:00
tirbison
d7fe83c256 DATAJDBC-507 - Optimistic locking version for non primitives start with 0.
This makes the behaviour consistent with that of other Spring Data modules.

Original pull request: #208.
2020-04-20 12:42:40 +02:00
Jens Schauder
2b6f7b2b48 DATAJDBC-480 - Removed various deprecated symbols.
Removal of public API that was deprecated in version 1.1 or older.

Original pull request: #204.
2020-04-01 13:57:21 +02:00
Mark Paluch
c0803ddafe DATAJDBC-341 - Polishing.
Remove SpecialColumnValue in favor of JdbcPropertyValueProvider.hasProperty(…). Rename ResultSetWrapper to ResultSetAccessor. Replace ResultSetAccessor usage in JdbcConverter with ResultSet to avoid visibility issues.

Original pull request: #201.
2020-03-31 11:46:58 +02:00
Jens Schauder
95ca73df2f DATAJDBC-341 - Reworked the changes.
Turns out this was a little more involved than expected.
This modifies the implementation to not use exceptions for flow control.

Properties that get set via setter, wither or field access get not invoked for missing columns.
When properties get referenced in constructors a missing column results in an exception.

As a side effect we now access the `ResultSet` by index.
Depending on how the driver is implemented this might improve the performance a little.

Original pull request: #201.
2020-03-31 11:46:43 +02:00
Thomas Lang
c2062dbb9d DATAJDBC-341 - Map NULL values in EntityRowMapper for columns not being fetched in the query.
Original pull request: #170.
2020-03-30 19:55:41 +02:00
Mark Paluch
6769528068 DATAJDBC-453 - Polishing.
Remove unused AggregateChangeExecutionContext. Extract MutableAggregateChange interface and use it to encapsulate the implementation class. Expose MutableAggregateChange in entity callbacks where mutation of the MutableAggregateChange is intended.

Fix generics and license headers, tweak Javadoc.

Original pull request: #197.
2020-03-30 14:08:15 +02:00
Jens Schauder
51b6784579 DATAJDBC-453 - DbActions and AggregateChange are effectively immutable.
Removed the Interpreter and replaced it with AggregateChangeExecutor and  AggregateChangeExecutionContext.
The latter handles the mutable data like ids and versions.

Original pull request: #197.
2020-03-30 14:08:03 +02:00
Mark Paluch
d61651ad1e DATAJDBC-514 - Polishing.
Use AssertJ version specified by Spring Data Build.

Original pull request: spring-projects/spring-data-r2dbc#295.
2020-03-27 16:12:05 +01:00
Jens Schauder
beaeb5cbdf DATAJDBC-512 - Polishing.
Removed some accidental leftovers from the development process.
Added a note in the `new-features`.

Original pull request: #203.
2020-03-26 17:22:44 +01:00
Mark Paluch
4e23fa6fdf DATAJDBC-512 - Add support H2 dialect.
Original pull request: #203.
2020-03-26 17:22:44 +01:00
Mark Paluch
ef02b6e9cd DATAJDBC-455 - Polishing.
Rename Dialect bean to jdbcDialect to avoid generic bean names. Require JdbcOperations in DialectResolver. Rename JdbcDialectResolver to DialectResolver for consistent naming with R2DBC the underlying type is a Dialect.

Tweak Javadoc and extend documentation with custom conversions include from Spring Data Commons. Extract MySQL identifier processing defaults into constant.

Original pull request: #202.
2020-03-26 11:08:55 +01:00
Jens Schauder
956ad24d4f DATAJDBC-487 - Makes the IdentifierProcessing for MySqlDialect dynamic.
This allows to handle the various ways MySQL may behave, depending on the OS it is installed on and on its configuration.

Original pull request: #202.
2020-03-26 11:08:49 +01:00
Jens Schauder
4c3fa05b6c DATAJDBC-455 - Adds dynamic Dialect detection.
So far the user had to specify an `Dialect` themselves if they wanted to use anything but HSQLDB.
We now identify the supported databases and pick the appropriate `Dialect`.

Vendors who want to offer support for their database may provide an implementation of `JdbcDialectProvider` and register it using a  file under the key `org.springframework.data.jdbc.repository.config.DialectResolver$JdbcDialectProvider`.

Original pull request: #202.
2020-03-26 11:08:14 +01:00
Jens Schauder
36192c4d97 DATAJDBC-510 - Polishing.
Minor formatting and removal of a deprecated constructor since this is for a major release anyway.

Original pull request: #192.
2020-03-25 13:49:39 +01:00
mhyeon-lee
54fed8ac5f DATAJDBC-510 - Inject IdentifierProcessing into BasicJdbcConverter.
Before the `IdentifierProcessing` was hardcoded and therefore did not match a properly configured `Dialect`.

Original pull request: #192.
2020-03-25 13:49:27 +01:00
Jens Schauder
5fdfd3a9dc DATAJDBC-454 - Adds generics to events.
Events now have a type parameter for the type of aggregate root they relate to.
In order to utilize this an react to only events relating to a specific type of entity `AbstractRelationalEventListener` was added.

Original pull request: #199.
2020-03-19 09:21:56 +01:00
Jens Schauder
22f9eded60 DATAJDBC-454 - Redesigned events.
Ids are only contained if it can not be guaranteed that an entity is contained which applies to the delete events.
As a side effect Identifier got simplified into a single simple class.

Original pull request: #199.
2020-03-19 09:21:41 +01:00
Michal Fotyga
7a2a3fb2eb DATAJDBC-506 - Fix some typos in code and documentation.
Original pull request: #200.
2020-03-16 08:56:01 +01:00
Mark Paluch
0ba523c780 DATAJDBC-503 - Adapt to Mockito 3.3 changes.
Mockito reports falsely unnecessary stubbings so we're switching to the silent runner for these cases.
2020-03-11 09:00:20 +01:00
Mark Paluch
188b9d4388 DATAJDBC-491 - Correctly combine schema- and table name.
We no correctly combine schema and table name using separate SqlIdentifier objects instead of leaving the schema name as part of the table name. Previously, the concatenated name failed to resolve with quoted identifiers.
2020-02-21 14:43:09 +01:00
Jens Schauder
c907eb1d35 DATAJDBC-488 - Polishing.
JdbcRepositoryConcurrencyIntegrationTests now only runs with MySql instead of always with MySql.
Also modified it to not use sleep.
Copyright header added.
Formatting.

Original pull request: #191.
2020-02-21 13:16:15 +01:00
mhyeon-lee
06529abf5a DATAJDBC-488 - Avoid deadlocks by first accessing the root entity.
The previous process of deleting referencing entities, updating the root and then inserting referencing entities hat the potential of causing deadlocks.
When one process didn't obtain a lock on delete because there wasn't anything to delete root and referencing entities got locks in opposite order, which is a classical cause for deadlocks.

Original pull request: #191.
2020-02-21 13:15:46 +01:00