Spring/spring-data-rest
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DATAREST-632 - Fixed gap in JSON Schema unit tests.

Browse Source 
Consolidated constraint tests for JSON Schema test for User and Profile.

Original pull request: #192.
This commit is contained in:
Greg Turnquist
2015-08-03 15:40:58 -04:00
committed by Oliver Gierke
parent 5dac9eac0c
commit 2244a2c588
1 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
spring-data-rest-webmvc/src/test/java/org/springframework/data/rest/webmvc/json/PersistentEntityToJsonSchemaConverterUnitTests.java
View File

@@ -52,6 +52,7 @@ import com.jayway.jsonpath.JsonPath;
/**
* @author Oliver Gierke
* @author Greg Turnquist
*/
@RunWith(SpringJUnit4ClassRunner.class)
@ContextConfiguration(classes = { MongoDbRepositoryConfig.class, TestConfiguration.class })
@@ -87,10 +88,14 @@ public class PersistentEntityToJsonSchemaConverterUnitTests {
converter = new PersistentEntityToJsonSchemaConverter(entities, mappings, accessor, objectMapper, configuration);
}
/**
* @see DATAREST-631, DATAREST-632
*/
@Test
public void fulfillsConstraintsForProfile() {
List<Constraint> constraints = new ArrayList<Constraint>();
constraints.add(new Constraint("$.properties.id", is(notNullValue()), "Has descriptor for id property"));
constraints.add(new Constraint("$.description", is("Profile description"), "Adds description to schema root"));
constraints.add(new Constraint("$.properties.renamed", is(notNullValue()), "Has descriptor for renamed property"));
constraints.add(
@@ -99,10 +104,14 @@ public class PersistentEntityToJsonSchemaConverterUnitTests {
assertConstraints(Profile.class, constraints);
}
/**
* @see DATAREST-632
*/
@Test
public void fulfilsConstraintsForUser() throws Exception {
public void fulfillsConstraintsForUser() throws Exception {
List<Constraint> constraints = new ArrayList<Constraint>();
constraints.add(new Constraint("$.properties.id", is(nullValue()), "Does NOT have descriptor for id property"));
constraints.add(new Constraint("$.properties.firstname.type", is("string"), "Exposes firstname as String"));
constraints
.add(new Constraint("$.descriptors.address", is(notNullValue()), "Exposes nested objects as descriptors."));
@@ -136,18 +145,6 @@ public class PersistentEntityToJsonSchemaConverterUnitTests {
assertConstraints(User.class, constraints);
}
/**
* @see DATAREST-631
*/
@Test
public void fulfilsConstraintsForProfile() {
List<Constraint> constraints = new ArrayList<Constraint>();
constraints.add(new Constraint("$.properties.id", is(notNullValue()), "Has descriptor for id property"));
assertConstraints(Profile.class, constraints);
}
@SuppressWarnings("unchecked")
private void assertConstraints(Class<?> type, Iterable<Constraint> constraints) {