Avoid manually handling additional primitive elements in collection merging for PATCHes.

Fixes #2261.
This commit is contained in:
Oliver Drotbohm
2023-05-23 15:51:53 +02:00
parent e9c43f1373
commit d6d8c50592
2 changed files with 47 additions and 4 deletions

View File

@@ -352,10 +352,7 @@ public class DomainObjectReader {
for (JsonNode jsonNode : array) {
if (!value.hasNext()) {
collection.add(mapper.treeToValue(jsonNode, getTypeToMap(null, componentType).getType()));
continue;
break;
}
Object next = value.next();

View File

@@ -58,6 +58,7 @@ import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonSubTypes;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
import com.fasterxml.jackson.annotation.JsonTypeInfo.As;
import com.fasterxml.jackson.core.JacksonException;
import com.fasterxml.jackson.core.JsonParser;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.DeserializationContext;
@@ -66,6 +67,8 @@ import com.fasterxml.jackson.databind.JsonMappingException;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.PropertyNamingStrategy;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
import com.fasterxml.jackson.databind.module.SimpleModule;
import com.fasterxml.jackson.databind.node.ObjectNode;
@@ -109,6 +112,7 @@ class DomainObjectReaderUnitTests {
mappingContext.getPersistentEntity(ArrayHolder.class);
mappingContext.getPersistentEntity(Apple.class);
mappingContext.getPersistentEntity(Pear.class);
mappingContext.getPersistentEntity(WithCustomMappedPrimitiveCollection.class);
mappingContext.afterPropertiesSet();
this.entities = new PersistentEntities(Collections.singleton(mappingContext));
@@ -645,6 +649,21 @@ class DomainObjectReaderUnitTests {
assertThat(result.inner).isSameAs(inner);
}
@Test // GH-2261
void deserializesCustomCollectionOfPrimitives() throws Exception {
var node = new ObjectMapper().readTree("""
{ "longs" : [ "foo:1", "bar:2" ] }
""");
var collection = new WithCustomMappedPrimitiveCollection();
collection.longs = List.of(3L);
var result = reader.doMerge((ObjectNode) node, collection, new ObjectMapper());
assertThat(result.longs).isEqualTo(List.of(1L, 2L));
}
@SuppressWarnings("unchecked")
private static <T> T as(Object source, Class<T> type) {
@@ -900,4 +919,31 @@ class DomainObjectReaderUnitTests {
static class Pear extends Fruit {
String pear;
}
// GH-2261
static class WithCustomMappedPrimitiveCollection {
@JsonDeserialize(contentUsing = CustomDeserializer.class) //
List<Long> longs;
@SuppressWarnings("serial")
static class CustomDeserializer extends StdDeserializer<Long> {
protected CustomDeserializer() {
super(Long.class);
}
/*
* (non-Javadoc)
* @see com.fasterxml.jackson.databind.JsonDeserializer#deserialize(com.fasterxml.jackson.core.JsonParser, com.fasterxml.jackson.databind.DeserializationContext)
*/
@Override
public Long deserialize(JsonParser p, DeserializationContext ctxt) throws IOException, JacksonException {
var elements = p.getText().split(":");
return Long.valueOf(elements[elements.length - 1]);
}
}
}
}