Spring/spring-data-rest
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PersistentEntitiesResourceMapping.hasMappingFor(…) should lookup metadata on cache miss.

Browse Source
This commit is contained in:
Oliver Drotbohm
2021-07-13 09:27:03 +02:00
parent c682ebbd1d
commit edba6ace12
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-data-rest-core/src/main/java/org/springframework/data/rest/core/mapping/PersistentEntitiesResourceMappings.java
View File

@@ -133,7 +133,7 @@ public class PersistentEntitiesResourceMappings implements ResourceMappings {
*/
@Override
public boolean hasMappingFor(Class<?> type) {
return cache.get(type) != null;
return getMappingMetadataFor(type) != null;
}
/*

14
spring-data-rest-core/src/test/java/org/springframework/data/rest/core/mapping/PersistentEntitiesResourceMappingsUnitTests.java
View File

@@ -39,4 +39,18 @@ public class PersistentEntitiesResourceMappingsUnitTests {
assertThat(mappings.getMetadataFor(String.class)).isNull();
assertThat(mappings.hasMappingFor(String.class)).isFalse();
}
@Test // GH-2033
public void transparentlyAddsValueToCacheOnHasMappingRequests() {
KeyValueMappingContext<?, ?> context = new KeyValueMappingContext<>();
context.getPersistentEntity(Sample.class);
PersistentEntitiesResourceMappings mappings = new PersistentEntitiesResourceMappings(
PersistentEntities.of(context));
assertThat(mappings.hasMappingFor(Sample.class)).isTrue();
}
class Sample {}
}