Remove warnings from the build

2020-02-11 11:58:57 -05:00
parent d8ae60ead7
commit 3347ecbc48
9 changed files with 892 additions and 38 deletions
--- a/angular.json
+++ b/angular.json
@@ -10,7 +10,7 @@
        "build": {
          "builder": "@angular-devkit/build-angular:browser",
          "options": {
-            "outputPath": "dist/app",
+            "outputPath": "dist-demo",
            "index": "src/demo/index.html",
            "main": "src/demo/main.ts",
            "tsConfig": "src/demo/tsconfig.dev.json",
@@ -81,7 +81,7 @@
        "build": {
          "builder": "@angular-devkit/build-angular:browser",
          "options": {
-            "outputPath": "dist/app",
+            "outputPath": "dist-demo",
            "index": "src/demo/index.html",
            "main": "src/demo/main.ts",
            "tsConfig": "src/demo/tsconfig.packaged.json",
--- a/package-lock.json
+++ b/package-lock.json
--- a/package.json
+++ b/package.json
@@ -2,15 +2,15 @@
  "name": "spring-flo",
  "version": "0.9.0",
  "description": "Library for quickly building text DSL visualization diagram editor",
-  "main": "dist/lib/bundles/spring-flo.umd.js",
-  "module": "dist/lib/fesm5/spring-flo.js",
-  "es2015": "dist/lib/fesm2015/spring-flo.js",
-  "esm5": "dist/lib/esm5/spring-flo.js",
-  "esm2015": "dist/lib/esm2015/spring-flo.js",
-  "fesm5": "dist/lib/fesm5/spring-flo.js",
-  "fesm2015": "dist/lib/fesm2015/spring-flo.js",
-  "typings": "dist/lib/spring-flo.d.ts",
-  "metadata": "dist/lib/spring-flo.metadata.json",
+  "main": "dist/bundles/spring-flo.umd.js",
+  "module": "dist/fesm5/spring-flo.js",
+  "es2015": "dist/fesm2015/spring-flo.js",
+  "esm5": "dist/esm5/spring-flo.js",
+  "esm2015": "dist/esm2015/spring-flo.js",
+  "fesm5": "dist/fesm5/spring-flo.js",
+  "fesm2015": "dist/fesm2015/spring-flo.js",
+  "typings": "dist/spring-flo.d.ts",
+  "metadata": "dist/spring-flo.metadata.json",
  "sideEffects": false,
  "author": "",
  "license": "Apache-2.0",
@@ -26,7 +26,7 @@
    "serve": "ng serve dev",
    "build:lib": "rimraf dist && ng-packagr -p src/lib/package.json && npm run styles:lib",
    "build:app": "cpr dist/lib src/demo/spring-flo -d && ng build packaged && rimraf src/demo/spring-flo",
-    "styles:lib": "scss-bundle --entryFile src/lib/styles.scss --outFile dist/lib/flo.css",
+    "styles:lib": "scss-bundle --entryFile src/lib/styles.scss --outFile dist/flo.css",
    "build": "npm run build:lib",
    "prestart": "npm run build:lib",
    "start": "npm run serve",
@@ -52,15 +52,18 @@
    "@angular/platform-browser": "9.0.0",
    "@angular/platform-browser-dynamic": "9.0.0",
    "@angular/platform-server": "9.0.0",
+    "@types/node": "6.0.46",
    "@types/backbone": "1.3.42",
    "@types/codemirror": "0.0.64",
    "@types/jasmine": "2.5.36",
    "@types/jquery": "3.3.4",
    "@types/lodash": "4.14.123",
-    "@types/node": "6.0.46",
    "core-js": "^3.6.4",
    "cpr": "^3.0.1",
+    "fibers": "^4.0.2",
+    "html-webpack-plugin": "^3.2.0",
    "jshint": "2.10.2",
+    "node-sass": "^4.13.1",
    "ng-packagr": "9.0.0",
    "ngx-bootstrap": "5.2.0",
    "rimraf": "2.6.1",
--- a/src/demo/app/app.component.ts
+++ b/src/demo/app/app.component.ts
@@ -1,5 +1,4 @@
 import { Component, ViewEncapsulation } from '@angular/core';
-import { NgModel } from '@angular/forms';
 import { Flo } from 'spring-flo';
 import { BsModalService } from 'ngx-bootstrap';
 const { Metamodel } = require('./metamodel');
--- a/src/lib/code-editor/code-editor.component.ts
+++ b/src/lib/code-editor/code-editor.component.ts
@@ -1,4 +1,4 @@
-import { Component, Input, Output, ElementRef, EventEmitter, OnInit, OnDestroy, ViewEncapsulation, forwardRef } from '@angular/core';
+import { Component, Input, Output, ElementRef, EventEmitter, OnInit, ViewEncapsulation, forwardRef } from '@angular/core';
 import { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';
 import * as CodeMirror from 'codemirror-minified';

@@ -44,7 +44,7 @@ import 'codemirror-minified/addon/scroll/simplescrollbars';
    }
  ]
 })
-export class CodeEditorComponent implements OnInit, OnDestroy, ControlValueAccessor {
+export class CodeEditorComponent implements OnInit, ControlValueAccessor {

  private doc: CodeMirror.EditorFromTextArea;

@@ -183,9 +183,6 @@ export class CodeEditorComponent implements OnInit, OnDestroy, ControlValueAcces
    this.doc.setOption('lint', this.getLintOptions());
  }

-  ngOnDestroy() {
-  }
-
  writeValue(obj: any): void {
    this.dsl = obj;
  }
--- a/src/lib/dsl-editor/dsl-editor.component.ts
+++ b/src/lib/dsl-editor/dsl-editor.component.ts
@@ -1,4 +1,4 @@
-import { Component, Input, Output, ElementRef, EventEmitter, OnInit, OnDestroy, ViewEncapsulation } from '@angular/core';
+import { Component, Input, Output, ElementRef, EventEmitter, OnInit, ViewEncapsulation } from '@angular/core';
 import * as _ from 'lodash';
 import * as CodeMirror from 'codemirror-minified';
 import * as _$ from 'jquery';
@@ -16,7 +16,7 @@ import 'codemirror-minified/addon/scroll/simplescrollbars';
  styleUrls: ['./dsl-editor.component.scss', ],
  encapsulation: ViewEncapsulation.None
 })
-export class DslEditorComponent implements OnInit, OnDestroy {
+export class DslEditorComponent implements OnInit {

  private doc: CodeMirror.EditorFromTextArea;

@@ -126,7 +126,4 @@ export class DslEditorComponent implements OnInit, OnDestroy {
    this.editor.emit(this.doc);
  }

-  ngOnDestroy() {
-  }
-
 }
--- a/src/lib/package.json
+++ b/src/lib/package.json
@@ -25,14 +25,21 @@
  },
  "ngPackage": {
    "lib": {
-      "entryFile": "./index.ts"
+      "entryFile": "./index.ts",
+      "umdModuleIds": {
+        "jointjs": "joint",
+        "jquery": "$",
+        "lodash": "_",
+        "ts-disposables": "tsDisposables",
+        "codemirror-minified": "codemirror"
+      }
    },
    "whitelistedNonPeerDependencies": [
      "codemirror-minified",
      "jointjs",
      "ts-disposables"
    ],
-    "dest": "../../dist/lib",
+    "dest": "../../dist",
    "deleteDestPath": true
  }
 }
--- a/src/lib/palette/palette.component.ts
+++ b/src/lib/palette/palette.component.ts
@@ -1,4 +1,4 @@
-import {Component, ElementRef, Input, Output, EventEmitter, OnInit, OnDestroy, OnChanges, SimpleChanges, Inject, ViewEncapsulation} from '@angular/core';
+import {Component, ElementRef, Input, Output, EventEmitter, OnInit, OnDestroy, Inject, ViewEncapsulation} from '@angular/core';
 import { Subject } from 'rxjs';
 import { debounceTime } from 'rxjs/operators';
 import { dia } from 'jointjs';
@@ -71,7 +71,7 @@ joint.shapes.flo.NoMatchesFound = joint.shapes.basic.Generic.extend({
  styleUrls: ['./palette.component.scss'],
  encapsulation: ViewEncapsulation.None
 })
-export class Palette implements OnInit, OnDestroy, OnChanges {
+export class Palette implements OnInit, OnDestroy {

  private _metamodelListener: Flo.MetamodelListener = {
    metadataError: (data) => {},
@@ -238,12 +238,6 @@ export class Palette implements OnInit, OnDestroy, OnChanges {
      this.palette.remove();
  }

-  ngOnChanges(changes: SimpleChanges) {
-    // if (changes.hasOwnProperty('paletteSize') || changes.hasOwnProperty('filterText')) {
-    //   this.metamodel.load().then(metamodel => this.buildPalette(metamodel));
-    // }
-  }
-
  private createPaletteGroup(title: string, isOpen: boolean): dia.Element {
    const paletteRenderer: Flo.PaletteRenderer = this.renderer && this.renderer.getPaletteRenderer ? this.renderer.getPaletteRenderer() : {
      createGroupHeader: (titleStr: string, isOpenParam: boolean) => {
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -19,7 +19,9 @@
      "node_modules/@types",
      "src/lib/@types"
    ],
-    "strictNullChecks":false,
-    "enableIvy": false
+    "strictNullChecks":false
+  },
+  "angularCompilerOptions": {
+    "enableIvy": true
  }
 }