Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reinstate -Werror for Groovy compilation

Browse Source 
This commit partially reverts cf2429b0f0
in order to reinstate -Werror for Groovy compilation in spring-beans.

The `decorating` field in GroovyDynamicElementReader has been changed
from boolean to Boolean in order to avoid the JDK 17 deprecation warning
for use of `new Boolean(false)` which the Groovy compiler apparently
uses behind the scenes when compiling Groovy source code.
This commit is contained in:
Sam Brannen
2021-09-21 11:30:30 +02:00
parent 69a46a7296
commit 070d087dbc
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spring-beans/spring-beans.gradle
View File

@@ -23,8 +23,7 @@ sourceSets {
}
compileGroovy {
// Groovy generates Java code with "new Boolean" usage which is deprecated on JDK 17
// options.compilerArgs += "-Werror"
options.compilerArgs += "-Werror"
}
// This module also builds Kotlin code and the compileKotlin task naturally depends on

2
spring-beans/src/main/groovy/org/springframework/beans/factory/groovy/GroovyDynamicElementReader.groovy
View File

@@ -40,7 +40,7 @@ class GroovyDynamicElementReader extends GroovyObjectSupport {
private final GroovyBeanDefinitionWrapper beanDefinition
protected final boolean decorating;
protected final Boolean decorating;
private boolean callAfterInvocation = true