Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix empty domain handling in ResponseCookie

Browse Source 
This commit also updates its test to use its intended inputs.
This commit is contained in:
Johnny Lim
2020-03-22 13:28:49 +09:00
committed by Rossen Stoyanchev
parent c24fa22a1b
commit 0f50a9a60a
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-web/src/main/java/org/springframework/http/ResponseCookie.java
View File

@@ -248,7 +248,7 @@ public final class ResponseCookie extends HttpCookie {
if (lenient && !StringUtils.isEmpty(domain)) {
String s = domain.trim();
if (s.startsWith("\"") && s.endsWith("\"")) {
if (s.substring(1, domain.length() - 1).trim().isEmpty()) {
if (s.substring(1, s.length() - 1).trim().isEmpty()) {
return null;
}
}

2
spring-web/src/test/java/org/springframework/http/ResponseCookieTests.java
View File

@@ -86,7 +86,7 @@ public class ResponseCookieTests {
Arrays.asList("\"\"", "\t\"\" ", " \" \t \"\t")
.forEach(domain -> {
ResponseCookie cookie = ResponseCookie.fromClientResponse("id", "1fWa").domain("\"\"").build();
ResponseCookie cookie = ResponseCookie.fromClientResponse("id", "1fWa").domain(domain).build();
assertThat(cookie.getDomain()).isNull();
});