Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Assert CronTriggerFactoryBean.setMisfireInstruction() values

Browse Source 
See gh-30851
This commit is contained in:
Sam Brannen
2023-07-31 15:50:15 +03:00
parent 12f765c133
commit 1378cce9fb
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-context-support/src/main/java/org/springframework/scheduling/quartz/CronTriggerFactoryBean.java
View File

@@ -207,6 +207,8 @@ public class CronTriggerFactoryBean implements FactoryBean<CronTrigger>, BeanNam
* Specify the misfire instruction for this trigger.
*/
public void setMisfireInstruction(int misfireInstruction) {
Assert.isTrue(constants.containsValue(misfireInstruction),
"Only values of misfire instruction constants allowed");
this.misfireInstruction = misfireInstruction;
}

13
spring-context-support/src/test/java/org/springframework/scheduling/quartz/CronTriggerFactoryBeanTests.java
View File

@@ -29,6 +29,8 @@ import org.springframework.util.ReflectionUtils;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
import static org.assertj.core.api.Assertions.assertThatNoException;
import static org.quartz.Trigger.MISFIRE_INSTRUCTION_IGNORE_MISFIRE_POLICY;
import static org.quartz.Trigger.MISFIRE_INSTRUCTION_SMART_POLICY;
/**
* Tests for {@link CronTriggerFactoryBean}.
@@ -68,6 +70,17 @@ class CronTriggerFactoryBeanTests {
.forEach(name -> assertThatNoException().as(name).isThrownBy(() -> factory.setMisfireInstructionName(name)));
}
@Test
void setMisfireInstruction() {
assertThatIllegalArgumentException().isThrownBy(() -> factory.setMisfireInstruction(999));
assertThatNoException().isThrownBy(() -> factory.setMisfireInstruction(MISFIRE_INSTRUCTION_SMART_POLICY));
assertThatNoException().isThrownBy(() -> factory.setMisfireInstruction(MISFIRE_INSTRUCTION_IGNORE_MISFIRE_POLICY));
assertThatNoException().isThrownBy(() -> factory.setMisfireInstruction(CronTrigger.MISFIRE_INSTRUCTION_FIRE_ONCE_NOW));
assertThatNoException().isThrownBy(() -> factory.setMisfireInstruction(CronTrigger.MISFIRE_INSTRUCTION_DO_NOTHING));
}
private static Stream<Field> streamMisfireInstructionConstants() {
return Arrays.stream(CronTrigger.class.getFields())
.filter(ReflectionUtils::isPublicStaticFinal)