Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid use of double constructor of BigDecimal

Browse Source 
Codacy warns about an Error Prone [1] use of the double constructor of
BigDecimal in tests. The reason given is that it is a source of
precision loss if the number does not have an exact double
representation. The recommendation is to use the String constructor of
BigDecimal instead as it does not require using a lossy argument.

This commit contains the following changes:

 - replace usage of the double constructor of BigDecimal with the
   String constructor of BigDecimal in JdbcTemplateQueryTests
 - update the copyright year

 [1] http://errorprone.info/bugpattern/BigDecimalLiteralDouble

Issue: SPR-15077
This commit is contained in:
Philippe Marschall
2016-12-31 12:15:31 +01:00
committed by Stephane Nicoll
parent df98d304fd
commit 3f97ab183e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-jdbc/src/test/java/org/springframework/jdbc/core/JdbcTemplateQueryTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2002-2015 the original author or authors.
* Copyright 2002-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -197,8 +197,8 @@ public class JdbcTemplateQueryTests {
public void testQueryForObjectWithBigDecimal() throws Exception {
String sql = "SELECT AGE FROM CUSTMR WHERE ID = 3";
given(this.resultSet.next()).willReturn(true, false);
given(this.resultSet.getBigDecimal(1)).willReturn(new BigDecimal(22.5));
assertEquals(new BigDecimal(22.5), this.template.queryForObject(sql, BigDecimal.class));
given(this.resultSet.getBigDecimal(1)).willReturn(new BigDecimal("22.5"));
assertEquals(new BigDecimal("22.5"), this.template.queryForObject(sql, BigDecimal.class));
verify(this.resultSet).close();
verify(this.statement).close();
}