Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #28472 from JiayiLi1999

Browse Source 
* pr/28472:
  Polish "Improve test coverage of RdbmsOperation"
  Improve test coverage of RdbmsOperation

Closes gh-28472
This commit is contained in:
Stephane Nicoll
2022-07-29 17:37:30 +02:00
parent 1bdb67cda9 f9ee8a93ad
commit 7b4a37f573
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spring-jdbc/src/test/java/org/springframework/jdbc/object/RdbmsOperationTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2002-2019 the original author or authors.
* Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -78,6 +78,7 @@ public class RdbmsOperationTests {
@Test
public void tooFewMapParameters() {
operation.setDataSource(new DriverManagerDataSource());
operation.setSql("select * from mytable");
operation.setTypes(new int[] { Types.INTEGER });
assertThatExceptionOfType(InvalidDataAccessApiUsageException.class).isThrownBy(() ->
@@ -85,22 +86,31 @@ public class RdbmsOperationTests {
}
@Test
public void operationConfiguredViaJdbcTemplateMustGetDataSource() throws Exception {
public void operationConfiguredViaJdbcTemplateMustGetDataSource() {
operation.setSql("foo");
assertThatExceptionOfType(InvalidDataAccessApiUsageException.class).isThrownBy(() ->
operation.compile())
.withMessageContaining("ataSource");
.withMessageContaining("'dataSource'");
}
@Test
public void tooManyParameters() {
operation.setDataSource(new DriverManagerDataSource());
operation.setSql("select * from mytable");
assertThatExceptionOfType(InvalidDataAccessApiUsageException.class).isThrownBy(() ->
operation.validateParameters(new Object[] { 1, 2 }));
}
@Test
public void tooManyMapParameters() {
operation.setDataSource(new DriverManagerDataSource());
operation.setSql("select * from mytable");
assertThatExceptionOfType(InvalidDataAccessApiUsageException.class).isThrownBy(() ->
operation.validateNamedParameters(Map.of("a", "b", "c", "d")));
}
@Test
public void unspecifiedMapParameters() {
operation.setDataSource(new DriverManagerDataSource());
operation.setSql("select * from mytable");
Map<String, String> params = new HashMap<>();
params.put("col1", "value");