Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #31328 from vpavic

Browse Source 
* pr/31328:
  Polish "Fix regression in JmsAccessor#setSessionAcknowledgeMode"
  Fix regression in JmsAccessor#setSessionAcknowledgeMode

Closes gh-31328
This commit is contained in:
Stéphane Nicoll
2023-09-29 08:43:26 +02:00
parent ce9ca700f3 95e6902aef
commit 9e144afc0d
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-jms/src/main/java/org/springframework/jms/support/JmsAccessor.java
View File

@@ -167,8 +167,6 @@ public abstract class JmsAccessor implements InitializingBean {
* @see jakarta.jms.Connection#createSession(boolean, int)
*/
public void setSessionAcknowledgeMode(int sessionAcknowledgeMode) {
Assert.isTrue(sessionConstants.containsValue(sessionAcknowledgeMode),
"Only values of acknowledge mode constants allowed");
this.sessionAcknowledgeMode = sessionAcknowledgeMode;
}

8
spring-jms/src/test/java/org/springframework/jms/support/JmsAccessorTests.java
View File

@@ -98,8 +98,6 @@ class JmsAccessorTests {
@Test
void setSessionAcknowledgeMode() {
assertThatIllegalArgumentException().isThrownBy(() -> accessor.setSessionAcknowledgeMode(999));
accessor.setSessionAcknowledgeMode(Session.AUTO_ACKNOWLEDGE);
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(Session.AUTO_ACKNOWLEDGE);
@@ -113,6 +111,12 @@ class JmsAccessorTests {
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(Session.SESSION_TRANSACTED);
}
@Test
void setCustomSessionAcknowledgeMode() {
accessor.setSessionAcknowledgeMode(999);
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(999);
}
@Test
void customAcknowledgeModeIsConsideredClientAcknowledge() throws Exception {
Session session = mock();