Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use Integer.parseInt instead of Integer.valueOf for primitive int

Browse Source 
Closes gh-25456
This commit is contained in:
XenoAmess
2020-07-22 16:54:32 +08:00
committed by GitHub
parent 24f9b1d966
commit cd12583e13
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-aspects/src/test/java/org/springframework/cache/aspectj/AbstractCacheAnnotationTests.java vendored
View File

@@ -416,11 +416,11 @@ public abstract class AbstractCacheAnnotationTests {
Integer three = 3;
Cache cache = this.cm.getCache("testCache");
assertThat((int) Integer.valueOf(service.conditionalUpdate(one).toString())).isEqualTo((int) one);
assertThat(Integer.parseInt(service.conditionalUpdate(one).toString())).isEqualTo((int) one);
assertThat(cache.get(one)).isNull();
assertThat((int) Integer.valueOf(service.conditionalUpdate(three).toString())).isEqualTo((int) three);
assertThat((int) Integer.valueOf(cache.get(three).get().toString())).isEqualTo((int) three);
assertThat(Integer.parseInt(service.conditionalUpdate(three).toString())).isEqualTo((int) three);
assertThat(Integer.parseInt(cache.get(three).get().toString())).isEqualTo((int) three);
}
protected void testMultiCache(CacheableService<?> service) {

2
spring-context/src/test/java/org/springframework/cache/config/EnableCachingIntegrationTests.java vendored
View File

@@ -195,7 +195,7 @@ public class EnableCachingIntegrationTests {
@Bean
public Bar bar() {
return new Bar(Boolean.valueOf(env.getProperty("bar.enabled")));
return new Bar(Boolean.parseBoolean(env.getProperty("bar.enabled")));
}

6
spring-context/src/testFixtures/java/org/springframework/context/testfixture/cache/AbstractCacheAnnotationTests.java vendored
View File

@@ -411,11 +411,11 @@ public abstract class AbstractCacheAnnotationTests {
Integer three = 3;
Cache cache = this.cm.getCache("testCache");
assertThat((int) Integer.valueOf(service.conditionalUpdate(one).toString())).isEqualTo((int) one);
assertThat(Integer.parseInt(service.conditionalUpdate(one).toString())).isEqualTo((int) one);
assertThat(cache.get(one)).isNull();
assertThat((int) Integer.valueOf(service.conditionalUpdate(three).toString())).isEqualTo((int) three);
assertThat((int) Integer.valueOf(cache.get(three).get().toString())).isEqualTo((int) three);
assertThat(Integer.parseInt(service.conditionalUpdate(three).toString())).isEqualTo((int) three);
assertThat(Integer.parseInt(cache.get(three).get().toString())).isEqualTo((int) three);
}
protected void testMultiCache(CacheableService<?> service) {

2
spring-core/src/test/java/org/springframework/util/xml/TransformerUtilsTests.java
View File

@@ -55,7 +55,7 @@ class TransformerUtilsTests {
void enableIndentingSunnyDayWithCustomKosherIndentAmount() throws Exception {
final String indentAmountProperty = "10";
Transformer transformer = new StubTransformer();
TransformerUtils.enableIndenting(transformer, Integer.valueOf(indentAmountProperty));
TransformerUtils.enableIndenting(transformer, Integer.parseInt(indentAmountProperty));
String indent = transformer.getOutputProperty(OutputKeys.INDENT);
assertThat(indent).isNotNull();
assertThat(indent).isEqualTo("yes");

2
spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/SockJsUrlInfoTests.java
View File

@@ -34,7 +34,7 @@ public class SockJsUrlInfoTests {
@Test
public void serverId() throws Exception {
SockJsUrlInfo info = new SockJsUrlInfo(new URI("https://example.com"));
int serverId = Integer.valueOf(info.getServerId());
int serverId = Integer.parseInt(info.getServerId());
assertThat(serverId >= 0 && serverId < 1000).as("Invalid serverId: " + serverId).isTrue();
}