Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MethodParameter.equals accepts subclasses pointing to same target declaration again

Browse Source 
Issue: SPR-14438
This commit is contained in:
Juergen Hoeller
2016-07-14 09:51:37 +02:00
parent 04e9c2bf0c
commit dd65689e0a
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-core/src/main/java/org/springframework/core/MethodParameter.java
View File

@@ -579,7 +579,7 @@ public class MethodParameter {
if (this == other) {
return true;
}
if (other == null || getClass() != other.getClass()) {
if (!(other instanceof MethodParameter)) {
return false;
}
MethodParameter otherParam = (MethodParameter) other;

5
spring-core/src/test/java/org/springframework/core/annotation/SynthesizingMethodParameterTests.java
View File

@@ -27,6 +27,7 @@ import static org.junit.Assert.*;
/**
* @author Juergen Hoeller
* @since 5.0
*/
public class SynthesizingMethodParameterTests {
@@ -69,8 +70,8 @@ public class SynthesizingMethodParameterTests {
assertNotEquals(methodParameter, longParameter);
methodParameter = new MethodParameter(method, 0);
assertNotEquals(stringParameter, methodParameter);
assertNotEquals(methodParameter, stringParameter);
assertEquals(stringParameter, methodParameter);
assertEquals(methodParameter, stringParameter);
assertNotEquals(longParameter, methodParameter);
assertNotEquals(methodParameter, longParameter);
}