Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing

Browse Source
This commit is contained in:
Juergen Hoeller
2023-11-30 16:36:45 +01:00
parent 5f9702b2a4
commit edfe179291
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
spring-jdbc/src/test/java/org/springframework/jdbc/datasource/DelegatingDataSourceTests.java
View File

@@ -40,6 +40,7 @@ public class DelegatingDataSourceTests {
private DelegatingDataSource dataSource = new DelegatingDataSource(delegate);
@Test
public void shouldDelegateGetConnection() throws Exception {
Connection connection = mock();
@@ -109,10 +110,12 @@ public class DelegatingDataSourceTests {
assertThat(dataSource.isWrapperFor(ExampleWrapper.class)).isTrue();
}
public interface ExampleWrapper {
}
private static class DelegatingDataSourceWithWrapper extends DelegatingDataSource
implements ExampleWrapper {
}
}

17
spring-jdbc/src/test/java/org/springframework/jdbc/datasource/DriverManagerDataSourceTests.java
View File

@@ -30,10 +30,11 @@ import static org.mockito.Mockito.mock;
*/
public class DriverManagerDataSourceTests {
private Connection connection = mock();
private final Connection connection = mock();
@Test
public void testStandardUsage() throws Exception {
public void standardUsage() throws Exception {
final String jdbcUrl = "url";
final String uname = "uname";
final String pwd = "pwd";
@@ -63,7 +64,7 @@ public class DriverManagerDataSourceTests {
}
@Test
public void testUsageWithConnectionProperties() throws Exception {
public void usageWithConnectionProperties() throws Exception {
final String jdbcUrl = "url";
final Properties connProps = new Properties();
@@ -96,7 +97,7 @@ public class DriverManagerDataSourceTests {
}
@Test
public void testUsageWithConnectionPropertiesAndUserCredentials() throws Exception {
public void usageWithConnectionPropertiesAndUserCredentials() throws Exception {
final String jdbcUrl = "url";
final String uname = "uname";
final String pwd = "pwd";
@@ -135,12 +136,12 @@ public class DriverManagerDataSourceTests {
}
@Test
public void testInvalidClassName() throws Exception {
public void invalidClassName() {
String bogusClassName = "foobar";
DriverManagerDataSource ds = new DriverManagerDataSource();
assertThatIllegalStateException().isThrownBy(() ->
ds.setDriverClassName(bogusClassName))
.withCauseInstanceOf(ClassNotFoundException.class);
assertThatIllegalStateException().isThrownBy(
() -> ds.setDriverClassName(bogusClassName))
.withCauseInstanceOf(ClassNotFoundException.class);
}
}