Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,357 Commits 18 Branches 0 Tags
129c05bcff4bcd99b3139577debb2391a1dfe099
Commit Graph

16357 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Juergen Hoeller
129c05bcff Comprehensively cache annotated methods for interfaces and superclasses 
Issue: SPR-16675
 2018-03-31 15:12:02 +02:00
Stephane Maldini
b8d32095a9 workaround multipart integration test using blocking receive inside netty thread 2018-03-30 15:43:11 -07:00
Juergen Hoeller
6393e5ce0c Consistent Ordered.LOWEST_PRECEDENCE declarations for default order 2018-03-31 00:20:44 +02:00
Juergen Hoeller
4da27c2a73 Avoid unnecessary introspection on methods and meta-annotations 
Issue: SPR-16667
 2018-03-31 00:18:14 +02:00
Rossen Stoyanchev
b1048975d2 Minor updates based on PR#1058 
The original repo no longer exists:
https://github.com/spring-projects/spring-framework/pull/1058
 2018-03-30 13:36:20 -04:00
Kazuki MATSUDA
d232fffa63 Use whenComplete since (null) return value not needed 2018-03-30 11:07:46 -04:00
Bian Jiaping
8f525f07e9 Fix typos, formatting and escaping in reference 
Note: Some symbol combinations (including <=) serve as textual symbol
replacements in AsciiDoc.

http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#text-replacement
 2018-03-30 10:06:33 -04:00
Juergen Hoeller
22a8a668c9 AnnotationTypeFilter assumes no custom annotations on common Java types 
Issue: SPR-16667
 2018-03-30 15:31:43 +02:00
Juergen Hoeller
78681c6369 JndiRmiServiceExporter still calls PortableRemoteObject when available 
Issue: SPR-16670
 2018-03-30 15:19:38 +02:00
Juergen Hoeller
0bc01fcd55 Polishing 2018-03-30 13:42:23 +02:00
Juergen Hoeller
7a8d41e5d6 Extended set of common classes and language interfaces in ClassUtils 
Issue: SPR-16667
 2018-03-30 13:41:22 +02:00
Johnny Lim
8dd0974e2f Rename SingleColumnRowMapperTest to align with the other tests 2018-03-30 12:28:16 +02:00
Sam Brannen
e5096be660 Polishing 2018-03-30 12:23:28 +02:00
Sam Brannen
f79562f8d1 Introduce tests for generics & @Nested test classes 2018-03-30 12:12:21 +02:00
Sam Brannen
a6c45f0cd9 Polishing 2018-03-30 11:45:28 +02:00
Rossen Stoyanchev
240d6f52c9 Replaces rather than prepend contextPath 
Issue: SPR-16650
 2018-03-29 18:17:29 -04:00
Juergen Hoeller
d553ddc5b3 Nullability refinements (based on IntelliJ IDEA 2018.1 introspection) 
Issue: SPR-15756
 2018-03-29 23:50:17 +02:00
Juergen Hoeller
1cc513d7db Consistent to/cc/bcc array handling and revised hashCode without text 
Issue: SPR-16671
 2018-03-29 23:44:04 +02:00
Juergen Hoeller
9a722b4558 Pass type name into PreparedStatement.setNull in case of Types.OTHER 
Issue: SPR-16669
 2018-03-29 23:43:53 +02:00
igor-suhorukov
93abe0e94b All branches in a conditional structure should not have exactly the same implementation 2018-03-29 23:33:50 +02:00
igor-suhorukov
ab96bb5428 Remove redundant check 2018-03-29 23:33:38 +02:00
igor-suhorukov
c1ff97e2a8 Short-circuit logic should be used in boolean contexts 2018-03-29 23:33:22 +02:00
Rossen Stoyanchev
dd96c873e3 Improve docs on forwarded headers 
Issue: SPR-16660
 2018-03-29 16:11:01 -04:00
Rossen Stoyanchev
a546cf0a3b Reject invalid forwarded headers 
Issue: SPR-16660
 2018-03-29 15:28:34 -04:00
Thor Andreas Rognan
5fb4c8254f Fix inclusion of license in jar 2018-03-29 12:30:28 -04:00
Rossen Stoyanchev
30b63a71bd Switch to Bismuth snapshots 2018-03-29 12:28:05 -04:00
Sam Brannen
9244090ba0 Support DI of individual constructor args in @Nested tests 
Prior to this commit it was impossible to have an individual
constructor argument in a @Nested (i.e., inner) test class injected via
@Autowired, @Qualifier, or @Value.

This is due to a bug in javac on JDK versions prior to 9, whereby
annotation lookups performed directly via the
java.lang.reflect.Parameter API fail for inner class constructors.

Specifically, the parameter annotations array in the compiled byte code
for the user's test class excludes an entry for the implicit enclosing
instance parameter for an inner class constructor.

This commit introduces a workaround in ParameterAutowireUtils for this
off-by-one error by transparently looking up annotations on the
preceding Parameter object (i.e., index - 1). In addition, this commit
relies on the change recently introduced in MethodParameter in order to
compensate for the same JDK bug (see SPR-16652).

Issue: SPR-16653
 2018-03-29 17:47:45 +02:00
Sam Brannen
17703e5dde Polishing 2018-03-29 17:45:55 +02:00
Sam Brannen
7c28152c13 Introduce ClassUtils.isInnerClass() utility method 2018-03-29 17:45:25 +02:00
Juergen Hoeller
b165475eb6 Polishing 2018-03-29 16:05:52 +02:00
Juergen Hoeller
08dad4e3ac Consistent references to primitive types (in alphabetical order) 2018-03-29 16:05:00 +02:00
Juergen Hoeller
695bf2961f Consistent trace logging in PathResourceResolver 
Issue: SPR-16616
 2018-03-29 16:04:33 +02:00
Juergen Hoeller
53d01392d7 Workaround for inner class constructor parameter annotation bug in javac 
Issue: SPR-16652
 2018-03-29 15:45:02 +02:00
Juergen Hoeller
3ac46da22f Correct description for doWithLocalFields 
Issue: SPR-16658
 2018-03-29 15:42:30 +02:00
nkjackzhang
82cb5dbf2b NamedParameterUtils.parseSqlStatement should parse :{x} style parameter correctly 
In my opinion, we should parse ":{x}" style parameter as "x" is parameter using "NamedParameterUtils.parseSqlStatement",
so the condition "j - i > 2" is the correct condition, not "j - i > 3", because if "i" is the index of
":" in ":{x}", and "j" is the index of "}" in ":{x}",  "j - i == 3" is true.
Also add a test case for SPR-16663.
 2018-03-29 15:00:25 +02:00
Stephane Nicoll
f4813f5b4c Merge pull request #1759 from igor-suhorukov 
* pr/1759:
  Nested "enum"s should not be declared static
 2018-03-29 09:13:18 +02:00
igor-suhorukov
8d2f64fe2d Nested "enum"s should not be declared static 
Closes gh-1759
 2018-03-29 09:12:03 +02:00
Rossen Stoyanchev
f9e6ea5482 MvcResult returns asyncResult after asyncDispatch 
Issue: SPR-16648
 2018-03-28 22:15:16 -04:00
igor-suhorukov
e6020ed377 avoid unnecessary autoboxing 2018-03-28 23:48:12 +02:00
Rossen Stoyanchev
b8d72516e1 Update link to WebSocket spec issue 2018-03-28 15:54:57 -04:00
Sam Brannen
4b9e3a9211 Introduce failing test for SPR-16652 
This commit introduces tests for looking up annotations on parameters
in constructors for nested and inner classes via Spring's
MethodParameter abstraction.

The test for an inner class is currently disabled since it fails on
JDK 8. See JIRA issue for details.

Issue: SPR-16652
 2018-03-28 17:42:55 +02:00
Juergen Hoeller
d95bbb6b1b Test for hasError keeping body available in case of unknown status code 
Issue: SPR-16604
 2018-03-28 12:16:03 +02:00
Juergen Hoeller
b2d87abcbb Polishing 2018-03-28 12:06:38 +02:00
Stephane Nicoll
d1a0b8d53f Clarify the format supported by @PropertySource 
Issue: SPR-16563
 2018-03-28 11:03:53 +02:00
Rossen Stoyanchev
5861e9685b Always specify charset for form data requests 
Issue: SPR-16613
 2018-03-27 19:56:09 -04:00
Rossen Stoyanchev
e00384a6fd MimeTypeUtils trims parameter names / values 
Issue: SPR-16630
 2018-03-27 19:56:09 -04:00
igor-suhorukov
4aae6a6dda Use Map.forEach instead of manual Map.Entry iteration wherever possible SPR-16646 2018-03-28 01:09:03 +02:00
Rossen Stoyanchev
224d52e032 Refine RequestedContentTypeResolver contract 
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.

Issue: SPR-16624
 2018-03-27 16:54:25 -04:00
Rossen Stoyanchev
f3994467c4 Refine ContentNegotiationStrategy contract 
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.

Issue: SPR-16624
 2018-03-27 16:54:19 -04:00
Juergen Hoeller
9a27bc9b3e Upgrade to Jackson 2.9.5 and Hibernate Validator 6.0.9 2018-03-27 17:33:34 +02:00