Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
17,517 Commits 18 Branches 0 Tags
f3c29fe2e6d2b1b1da4acc09d00bf2c67f10ff3e
Commit Graph

17517 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Arjen Poutsma
f3c29fe2e6 Add test for UriUtils.encode(String, Charset) 
Issue: SPR-17451
 2018-11-20 10:51:19 +01:00
Rossen Stoyanchev
abf9ce8a34 Improve handling of empty response with Mono<T> 
Issue: SPR-17560
 2018-11-19 16:48:38 -05:00
Arjen Poutsma
63275ae2b7 Add Test for LeakAwareDataBufferFactory 2018-11-19 16:56:25 +01:00
Brian Clozel
3203d39821 Remove Content-Length response header from errors 
Prior to this commit, when errors happened before the response was
committed, the `Content-Length` response header would be left as is.
This can be problematic since the error can be handled later in the
chain and the response body changed accordingly. For example, Spring
Boot renders error pages in those cases. If the `Content-Length` is set,
HTTP clients can get confused and only consider part of the error
response body.

This commit ensures that any `Content-Length` response header is removed
in case of errors, if the response is not already committed.

This is done at the `AbstractServerHttpResponse` level, since errors can
be handled in multiple places and the response itself is the safest
place to handle this case.

As a consequence, this commit also removes `Content-Length` checks in
`EncoderHttpMessageWriter` since we now consider that we should rely on
the response body we're about to write rather than any previously set
value.

Issue: SPR-17502
 2018-11-19 15:49:54 +01:00
Juergen Hoeller
ce5c65c0b0 Upgrade to JAXB 2.3.1, Groovy 2.5.4, Jetty 9.4.14, Tomcat 9.0.13 
Includes JAX-WS 2.3.1, Awaitility 3.1.3, OkHttp 3.12, Woodstox 5.2.
 2018-11-19 12:41:26 +01:00
Stephane Nicoll
afa38f5f97 Merge pull request #2019 from Hanope 
* pr/2019:
  Polish contribution
  Fix typos
 2018-11-19 08:50:49 +01:00
Stephane Nicoll
7b6f2f8fb3 Polish contribution 
Closes gh-2019
 2018-11-19 08:45:33 +01:00
Hanope
bfb49c7249 Fix typos 
See gh-2019
 2018-11-19 08:41:21 +01:00
HeemangHan
729ce4108d Correct typos (#2018) 2018-11-17 16:31:01 +01:00
Rossen Stoyanchev
1a37345e84 Fix checkstyle violation and polish 2018-11-16 19:42:42 -05:00
Rossen Stoyanchev
c89e6c616a Improve logging of request mapping information 
Issue: SPR-17450
 2018-11-16 17:30:18 -05:00
Arjen Poutsma
539cfc24c6 Refactor AbstractEncoderTestCase 
Refactor AbstractEncoderTestCase to resemble AbstractDecoderTestCase

Issue: SPR-17449
 2018-11-16 14:33:26 +01:00
Arjen Poutsma
39ce989d1a Add and use AbstractDecoderTestCase 
Introduce new base test case for decoder tests, and use it.

Issue: SPR-17449
 2018-11-16 14:33:26 +01:00
Brian Clozel
0f2d9df79f Upgrade to Reactor Californium SNAPSHOTs 2018-11-16 11:13:17 +01:00
Jay Bryant
b9603680bc Fixing typoes 
Jim Showalter found two typoes in the web section. This PR fixes them. Thanks, Jim.
 2018-11-14 16:10:17 -05:00
Rossen Stoyanchev
7bbd4c681f Merge pull request #2010 from dimitrisli/SPR-17459 2018-11-13 23:05:07 -05:00
Rossen Stoyanchev
ba3fef3e8a Refactor media types parsing improvements 
Issue: SPR-17459
 2018-11-13 23:02:09 -05:00
Dimitrios Liapis
f4b05dc2e7 MediaType parsing supports comma inside quotes 
Issue: SPR-17459
 2018-11-13 16:59:57 -05:00
Rossen Stoyanchev
46a5fb7a91 Configurable Marshaller/Unmarshaller in JAXB2 codecs 
Issue: SPR-17388
 2018-11-13 16:56:56 -05:00
Juergen Hoeller
093254b2b3 Jackson2ObjectMapperBuilder stores visibility declarations in order 
Issue: SPR-17489
 2018-11-13 21:17:55 +01:00
Rossen Stoyanchev
9f857c1f16 Replace constant exceptions with inlined ones 
Issue: SRP-17475
 2018-11-13 14:49:23 -05:00
Rossen Stoyanchev
75b1396768 Fall back on default server response status code 
Update the ServerHttpRespnose contract to indicate that server specific
sub-classes should fall back on the default status, if a status code
has not been set explicitly.

Issue: SPR-17368
 2018-11-13 14:10:48 -05:00
Arjen Poutsma
4182935b7a Revert optimization in StringDecoder 
This commit reverts the first optimizations listed in
fa096dc60f, as the default delimiters
do vary, namely by the charset given in the message mime type.
The mimetype charset might not be compatible with ASCII (i.e. anything
but UTF-8 or ISO-8859-1, for instance it might be UTF-16), and will not
successfully find the default delimiters as a consequence.

Added test to indicate the bug.
 2018-11-13 13:38:13 +01:00
Arjen Poutsma
445b76bbe8 Polishing 2018-11-13 13:35:37 +01:00
Arjen Poutsma
3bab3515b1 Add and use AbstractEncoderTestCase 
Introduce new base test case for encoder tests, and use it.

Issue: SPR-17449
 2018-11-13 13:35:37 +01:00
Arjen Poutsma
0c0de851f4 Add LeakAwareDataBufferFactory 
Introduce a data buffer factory that can check for memory leaks in
@After methods.

Issue: SPR-17449
 2018-11-13 13:35:37 +01:00
Arjen Poutsma
e31914bada Polishing 2018-11-13 13:35:37 +01:00
Juergen Hoeller
40148c0560 Consistent use of ResolvableType.toClass() for assignability checks 
Issue: SPR-17086
 2018-11-12 20:29:37 +01:00
Juergen Hoeller
3a66927bd2 Polishing 2018-11-12 16:43:43 +01:00
Juergen Hoeller
c58da71006 Synthesize parameter annotations from interface methods as well 
Issue: SPR-17460
 2018-11-12 16:23:14 +01:00
Juergen Hoeller
818c2aa3b9 ServerRequest.attribute(name) defensively accesses concurrent map 
Issue: SPR-17486
 2018-11-12 16:22:42 +01:00
Juergen Hoeller
d96a7b4bfc ClientRequest.attribute(name) defensively handles null value 
Issue: SPR-17486
 2018-11-12 11:52:21 +01:00
Sam Brannen
b3aad549c9 Fix @since tag 2018-11-10 16:56:39 +01:00
Sam Brannen
865f1f692a Introduce tests for @Sql and @Transactional support in @Nested test classes 
This commit was inspired by the following question on Stack Overflow.

https://stackoverflow.com/questions/53236807/spring-boot-testing-run-script-in-a-nested-test-sql-script-sql
 2018-11-10 15:47:30 +01:00
Sam Brannen
93df24af16 Polishing 2018-11-10 15:47:29 +01:00
Rossen Stoyanchev
a5339d71ea WebClient handles no Content-Type with data correctly 
Issue: SPR-17482
 2018-11-09 16:16:03 -05:00
Rossen Stoyanchev
e4c84ec757 Consistent default encoding in DefaultUriBuilderFactory 
Issue: SPR-17465
 2018-11-09 14:13:51 -05:00
Rossen Stoyanchev
f5da737bd4 Polish 2018-11-08 23:13:48 -05:00
Rossen Stoyanchev
c187cb2fa1 Ensure client response is drained with onStatus hook 
Issue: SPR-17473
 2018-11-08 22:41:22 -05:00
Rossen Stoyanchev
ed1d63dcc3 ResolvableMethod copy in spring-messaging src/test 2018-11-08 13:29:21 -05:00
Juergen Hoeller
e26ae9853e Up-to-date version and link in ASM/CGLIB/Objenesis package javadoc 
Issue: SPR-17267
Issue: SPR-17372
 2018-11-08 16:56:48 +01:00
Juergen Hoeller
362c59c310 Consistently return empty array in case of empty batch arguments 
Issue: SPR-17476
 2018-11-08 13:43:07 +01:00
Stephane Nicoll
b6e8674700 Merge pull request #2011 from bactoria 
* pr/2011:
  Fix typo
 2018-11-07 07:48:22 +01:00
황준오
db8a94ce5f Fix typo 
Closes gh-2011
 2018-11-07 07:47:55 +01:00
Stephane Nicoll
3232825a55 Clarify @Async documentation 
Issue: SPR-17458
 2018-11-06 08:30:30 +01:00
Juergen Hoeller
e71ff2901a Polishing 2018-11-05 22:59:33 +01:00
Juergen Hoeller
d9c1811d21 Deprecate NON_BRIDGED_METHODS constant as of 5.0.11 as well 
Issue: SPR-17464
 2018-11-05 22:59:18 +01:00
Juergen Hoeller
5e7a8b275d Polishing 2018-11-05 19:33:24 +01:00
Juergen Hoeller
ea3250c8d6 Explicit notes on class/method-level semantics in class hierarchies 
Issue: SPR-17445
 2018-11-05 19:32:34 +01:00
Juergen Hoeller
b1f5f51503 Synchronized onRefresh execution for concurrent ContextRefreshedEvent 
Issue: SPR-17442
 2018-11-05 19:27:43 +01:00