Brian Clozel a8091b916b Avoid closing Jackson JsonGenerator for error cases
Prior to this commit, a change introduced in gh-25910 would close the
`JsonGenerator` after it's been used for JSON serialization. This would
not only close it and recycle resources, but also flush the underlyning
buffer to the output.
In a case where the JSON serialization process would throw an exception,
the buffer would be still flushed to the response output. Before the
change introduced in gh-25910, the response body could be still empty at
that point and error handling could write an error body instead.

This commits only closes the `JsonGenerator` when serialization has been
successful.

Note that we're changing this in the spirit of backwards compatibility
in the 5.2.x line, but change this won't be merged forward on the 5.3.x
line, for several reasons:

* this behavior is not consistent. If the JSON output exceeds a
certain size, or if Jackson has been configured to flush after each
write, the response output might still contain an incomplete JSON
payload (just like before this change)

* this behavior is not consistent with the WebFlux and Messaging codecs,
which are flushing or closing the generator

* not closing the generator for error cases prevents resources from
being recycled as expected by Jackson

Fixes gh-26246
2020-12-08 20:50:26 +01:00
2020-03-14 10:06:25 +01:00
2020-11-27 21:58:55 +01:00
2020-11-05 18:18:38 +01:00
2020-11-16 17:50:15 +01:00
2020-11-27 21:58:55 +01:00
2020-12-07 22:09:43 +01:00
2020-01-28 21:56:35 +01:00
2020-09-25 11:26:01 +02:00
2020-11-09 13:52:34 +01:00
2017-06-12 08:07:54 +02:00
2014-10-05 18:12:50 +02:00
2019-03-21 15:08:55 -05:00
2020-04-20 12:32:11 +01:00
2020-11-10 07:09:28 +00:00
2019-08-17 19:20:36 +02:00
2019-10-18 10:38:40 +02:00
2019-03-21 15:08:55 -05:00
2019-08-20 22:01:12 +02:00
2019-11-05 15:20:18 +01:00
2019-05-23 11:36:52 -04:00
2019-12-02 16:43:02 +01:00

Spring Framework Build Status

This is the home of the Spring Framework: the foundation for all Spring projects. Collectively the Spring Framework and the family of Spring projects are often referred to simply as "Spring".

Spring provides everything required beyond the Java programming language for creating enterprise applications for a wide range of scenarios and architectures. Please read the Overview section as reference for a more complete introduction.

Code of Conduct

This project is governed by the Spring Code of Conduct. By participating, you are expected to uphold this code of conduct. Please report unacceptable behavior to spring-code-of-conduct@pivotal.io.

Access to Binaries

For access to artifacts or a distribution zip, see the Spring Framework Artifacts wiki page.

Documentation

The Spring Framework maintains reference documentation (published and source), Github wiki pages, and an API reference. There are also guides and tutorials across Spring projects.

Build from Source

See the Build from Source Wiki page and the CONTRIBUTING.md file.

Stay in Touch

Follow @SpringCentral, @SpringFramework, and its team members on Twitter. In-depth articles can be found at The Spring Blog, and releases are announced via our news feed.

License

The Spring Framework is released under version 2.0 of the Apache License.

Description
No description provided
Readme 248 MiB
Languages
Java 99.4%
XSLT 0.2%
AspectJ 0.2%