Spring/spring-graphql
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing contribution

Browse Source 
Closes: gh-1225
This commit is contained in:
rstoyanchev
2025-05-29 17:07:52 +01:00
parent d3ff9687eb
commit 14baa4e32a
1 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
spring-graphql/src/main/java/org/springframework/graphql/data/federation/FederationSchemaFactory.java
View File

@@ -193,9 +193,11 @@ public final class FederationSchemaFactory
private void checkEntityMappings(TypeDefinitionRegistry registry) {
List<String> unmappedEntities = new ArrayList<>();
for (TypeDefinition<?> type : registry.types().values()) {
if (isEntityMappingExpected(type) && !this.handlerMethods.containsKey(type.getName())) {
unmappedEntities.add(type.getName());
}
type.getDirectives().forEach((directive) -> {
if (isResolvableKeyDirective(directive) && !this.handlerMethods.containsKey(type.getName())) {
unmappedEntities.add(type.getName());
}
});
}
if (!unmappedEntities.isEmpty()) {
throw new IllegalStateException("Unmapped entity types: " +
@@ -203,22 +205,19 @@ public final class FederationSchemaFactory
}
}
/**
* Determine if a handler method is expected for this type: there is at least one '@key' directive
* whose 'resolvable' argument resolves to true (either explicitly, or if the argument is not set).
* @param type the type to inspect.
* @return true if a handler method is expected for this type
*/
private boolean isEntityMappingExpected(TypeDefinition<?> type) {
List<Directive> keyDirectives = type.getDirectives("key");
return !keyDirectives.isEmpty() && keyDirectives.stream()
.anyMatch((keyDirective) -> {
Argument resolvableArg = keyDirective.getArgument("resolvable");
return resolvableArg == null ||
(resolvableArg.getValue() instanceof BooleanValue) && ((BooleanValue) resolvableArg.getValue()).isValue();
});
private boolean isResolvableKeyDirective(Directive directive) {
if (!directive.getName().equalsIgnoreCase("key")) {
return false;
}
Argument argument = directive.getArgument("resolvable");
if (argument != null) {
Object value = argument.getValue();
return (value instanceof BooleanValue bv && bv.isValue());
}
return true;
}
public record EntityMappingInfo(String typeName, HandlerMethod handlerMethod) {
public boolean isBatchHandlerMethod() {