Spring/spring-graphql
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reduce allocations for empty ArgumentValue

Browse Source 
Closes gh-1175

Signed-off-by: James Bodkin <james.bodkin@amphora.net>
[brian.clozel@broadcom.com: apply code conventions]
Signed-off-by: Brian Clozel <brian.clozel@broadcom.com>
This commit is contained in:
James Bodkin
2025-04-03 16:02:36 +01:00
committed by Brian Clozel
parent e2f954a2cf
commit eb5a83ab6a
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spring-graphql/src/main/java/org/springframework/graphql/data/ArgumentValue.java
View File

@@ -49,6 +49,8 @@ import org.springframework.util.ObjectUtils;
*/
public final class ArgumentValue<T> {
private static final ArgumentValue<?> EMPTY = new ArgumentValue<>(null, false);
private static final ArgumentValue<?> OMITTED = new ArgumentValue<>(null, true);
@@ -118,7 +120,7 @@ public final class ArgumentValue<T> {
@Override
public boolean equals(Object other) {
// This covers OMITTED constant
// This covers EMPTY and OMITTED constant
if (this == other) {
return true;
}
@@ -142,8 +144,9 @@ public final class ArgumentValue<T> {
* @param <T> the type of value
* @param value the value to hold in the instance
*/
@SuppressWarnings("unchecked")
public static <T> ArgumentValue<T> ofNullable(@Nullable T value) {
return new ArgumentValue<>(value, false);
return (value != null) ? new ArgumentValue<>(value, false) : (ArgumentValue<T>) EMPTY;
}
/**

1
spring-graphql/src/test/java/org/springframework/graphql/data/ArgumentValueTests.java
View File

@@ -74,7 +74,6 @@ class ArgumentValueTests {
}
@Test
void ifPresentShouldSkipWhenOmitted() {
AtomicBoolean called = new AtomicBoolean();
ArgumentValue.omitted().ifPresent(value -> called.set(true));