Spring/spring-guice
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#78 prevent repeated NoSuchBeanDefinitionException's for JIT bindings

Browse Source
This commit is contained in:
Taylor Wicksell
2020-08-17 13:31:55 -07:00
committed by Taylor Wicksell
parent 7567e57ee1
commit e536f4ac9d
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/main/java/org/springframework/guice/module/GuiceAutowireCandidateResolver.java
View File

@@ -28,10 +28,12 @@ import org.springframework.beans.factory.support.DefaultListableBeanFactory;
import org.springframework.context.annotation.ContextAnnotationAutowireCandidateResolver;
import org.springframework.util.Assert;
import javax.inject.Provider;
import java.util.Collection;
import java.util.Map;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;
/**
@@ -86,6 +88,8 @@ class GuiceAutowireCandidateResolver extends ContextAnnotationAutowireCandidateR
"BeanFactory needs to be a DefaultListableBeanFactory");
final DefaultListableBeanFactory beanFactory = (DefaultListableBeanFactory) getBeanFactory();
TargetSource ts = new TargetSource() {
private Optional<Boolean> isGuiceResolvable = Optional.empty();
@Override
public Class<?> getTargetClass() {
return descriptor.getDependencyType();
@@ -99,14 +103,18 @@ class GuiceAutowireCandidateResolver extends ContextAnnotationAutowireCandidateR
@Override
public Object getTarget() {
Object target = null;
try {
target = beanFactory.doResolveDependency(descriptor, beanName, null, null);
} catch (NoSuchBeanDefinitionException e) {
if (isGuiceResolvable.isPresent() && isGuiceResolvable.get()) {
target = injectorProvider.get().getInstance(Key.get(descriptor.getResolvableType().getType()));
} else {
try {
target = beanFactory.doResolveDependency(descriptor, beanName, null, null);
} catch (NoSuchBeanDefinitionException e) {
target = injectorProvider.get().getInstance(Key.get(descriptor.getResolvableType().getType()));
isGuiceResolvable = Optional.of(true);
}
}
if (target == null) {
throw new NoSuchBeanDefinitionException(descriptor.getDependencyType(),
throw new NoSuchBeanDefinitionException(descriptor.getDependencyType(),
"Optional dependency not present for lazy injection point");
}
return target;