Spring/spring-hateoas
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#1609 - Avoid superfluous object creation in Link.valueOf(…).

Browse Source 
We now avoid calling with…-methods for every attribute parsed from an RFC-8288 link string.
This commit is contained in:
Oliver Drotbohm
2021-09-16 11:28:00 +02:00
parent 2751b11acf
commit 140ae541f6
1 changed files with 11 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/main/java/org/springframework/hateoas/Link.java
View File

@@ -473,37 +473,18 @@ public class Link implements Serializable {
throw new IllegalArgumentException("Link does not provide a rel attribute!");
}
Link link = of(matcher.group(1), attributes.get("rel"));
LinkRelation rel = LinkRelation.of(attributes.get("rel"));
String href = matcher.group(1);
String hrefLang = attributes.get("hreflang");
String media = attributes.get("media");
String title = attributes.get("title");
String type = attributes.get("type");
String deprecation = attributes.get("deprecation");
String profile = attributes.get("profile");
String name = attributes.get("name");
if (attributes.containsKey("hreflang")) {
link = link.withHreflang(attributes.get("hreflang"));
}
if (attributes.containsKey("media")) {
link = link.withMedia(attributes.get("media"));
}
if (attributes.containsKey("title")) {
link = link.withTitle(attributes.get("title"));
}
if (attributes.containsKey("type")) {
link = link.withType(attributes.get("type"));
}
if (attributes.containsKey("deprecation")) {
link = link.withDeprecation(attributes.get("deprecation"));
}
if (attributes.containsKey("profile")) {
link = link.withProfile(attributes.get("profile"));
}
if (attributes.containsKey("name")) {
link = link.withName(attributes.get("name"));
}
return link;
return new Link(rel, href, hrefLang, media, title, type, deprecation, profile, name, templateOrNull(href),
Collections.emptyList());
} else {
throw new IllegalArgumentException(String.format("Given link header %s is not RFC-8288 compliant!", element));