Spring/spring-hateoas
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#1561 - Support for implicitly not required request parameters.

Browse Source 
Handler method parameters annotated with @RequestParam(defaultValue = …) are implicitly not required and thus should still be advertised in the URI templated generated. Previously it was necessary to explicitly set @RequestParam(required = …) to false.

Original pull request: #1511.
Related ticket: #331.
This commit is contained in:
Florian Cramer
2021-04-10 22:47:08 +02:00
committed by Oliver Drotbohm
parent dd51b54204
commit 9ee4b8e1ec
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/springframework/hateoas/server/core/WebHandler.java
View File

@@ -460,7 +460,7 @@ public class WebHandler {
RequestParam annotation = parameter.getParameterAnnotation(RequestParam.class);
if (!(annotation != null && annotation.required()) || parameter.isOptional()) {
if (!isRequired() || parameter.isOptional()) {
return SKIP_VALUE;
}

4
src/test/java/org/springframework/hateoas/server/mvc/WebMvcLinkBuilderUnitTest.java
View File

@@ -465,14 +465,14 @@ class WebMvcLinkBuilderUnitTest extends TestUtils {
}
/**
* @see #331
* @see #331, #545
*/
@Test
void linksToMethodWithRequestParamImplicitlySetToFalse() {
Link link = linkTo(methodOn(ControllerWithMethods.class).methodForOptionalSizeWithDefaultValue(null)).withSelfRel();
assertThat(link.getHref()).endsWith("/bar");
assertThat(link.getHref()).endsWith("/bar{?size}");
}
/**