Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary Thread.sleep() from the AsyncGatewayTests

Browse Source 
Such a `Thread.sleep()` makes tests slower, plus may cause a longer timing issue on slow CI/CD when CPU resources are limited

**Auto-cherry-pick to `6.3.x` & `6.2.x`**
This commit is contained in:
Artem Bilan
2024-11-14 14:49:52 -05:00
parent 4ccec0bae3
commit 09750f2012
1 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spring-integration-core/src/test/java/org/springframework/integration/gateway/AsyncGatewayTests.java
View File

@@ -110,7 +110,6 @@ public class AsyncGatewayTests {
proxyFactory.afterPropertiesSet();
TestEchoService service = proxyFactory.getObject();
CompletableFuture<Message<?>> f = service.returnMessageListenable("foo");
long start = System.currentTimeMillis();
final AtomicReference<Message<?>> result = new AtomicReference<>();
final CountDownLatch latch = new CountDownLatch(1);
f.whenComplete((message, throwable) -> {
@@ -120,8 +119,6 @@ public class AsyncGatewayTests {
}
});
assertThat(latch.await(10, TimeUnit.SECONDS)).isTrue();
long elapsed = System.currentTimeMillis() - start;
assertThat(elapsed >= 200).isTrue();
assertThat(result.get().getPayload()).isEqualTo("foobar");
Object thread = result.get().getHeaders().get("thread");
assertThat(thread).isNotEqualTo(Thread.currentThread());
@@ -363,13 +360,7 @@ public class AsyncGatewayTests {
Message<?> reply = MessageBuilder.withPayload(payload)
.copyHeaders(input.getHeaders())
.build();
try {
Thread.sleep(200);
}
catch (InterruptedException e) {
Thread.currentThread().interrupt();
return;
}
String header = (String) input.getHeaders().get("method");
if (header != null && header.startsWith("returnCustomFuture")) {
reply = MessageBuilder.withPayload(new CustomFuture(payload,