Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

INT-3316 BeanFactoryTypeConverter Concurrency

Browse Source 
JIRA: https://jira.spring.io/browse/INT-3316

The `SimpleTypeConverter` delegate uses property editors
which are not thread safe. We protect against concurrent
access when the source is not a String, but when a String,
we delegate to the `STC`.

Synchronize access to the `STC.convertIfNecessary()` method.
This commit is contained in:
Gary Russell
2014-03-10 12:29:39 -04:00
committed by Artem Bilan
parent 8933d7ff4e
commit 225e315e20
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-integration-core/src/main/java/org/springframework/integration/util/BeanFactoryTypeConverter.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2002-2013 the original author or authors.
* Copyright 2002-2014 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -139,7 +139,9 @@ public class BeanFactoryTypeConverter implements TypeConverter, BeanFactoryAware
return convertValue(text, TypeDescriptor.valueOf(String.class), targetType);
}
}
return delegate.convertIfNecessary(value, targetType.getType());
synchronized (this.delegate) {
return delegate.convertIfNecessary(value, targetType.getType());
}
}
private PropertyEditor getDefaultEditor(Class<?> sourceType) {
@@ -157,4 +159,4 @@ public class BeanFactoryTypeConverter implements TypeConverter, BeanFactoryAware
return defaultEditor;
}
}
}