Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

INT-4493: ZK MStore binary compatiblity

Browse Source 
JIRA: https://jira.spring.io/browse/INT-4493

Use reflection to enable binary compatibility with curator 4.x.

The return type of `ExistsBuilder.creatingParentContainersIfNeeded()` is now
a sub-interface of `ExistsBuilderMain`.

Tested with a boot app with curator 4.0.1.

* Polishing - add cause
This commit is contained in:
Gary Russell
2018-06-27 11:55:36 -04:00
committed by Artem Bilan
parent 67fdac89f3
commit 493b4aa091
1 changed files with 29 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
spring-integration-zookeeper/src/main/java/org/springframework/integration/zookeeper/metadata/ZookeeperMetadataStore.java
View File

@@ -16,12 +16,16 @@
package org.springframework.integration.zookeeper.metadata;
import java.lang.reflect.Method;
import java.util.List;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.atomic.AtomicReference;
import org.apache.curator.framework.CuratorFramework;
import org.apache.curator.framework.api.ExistsBuilder;
import org.apache.curator.framework.api.ExistsBuilderMain;
import org.apache.curator.framework.recipes.cache.ChildData;
import org.apache.curator.framework.recipes.cache.PathChildrenCache;
import org.apache.curator.framework.recipes.cache.PathChildrenCacheEvent;
@@ -35,6 +39,7 @@ import org.springframework.integration.metadata.ListenableMetadataStore;
import org.springframework.integration.metadata.MetadataStoreListener;
import org.springframework.integration.support.utils.IntegrationUtils;
import org.springframework.util.Assert;
import org.springframework.util.ReflectionUtils;
/**
* Zookeeper-based {@link ListenableMetadataStore} based on a Zookeeper node.
@@ -48,6 +53,26 @@ import org.springframework.util.Assert;
*/
public class ZookeeperMetadataStore implements ListenableMetadataStore, SmartLifecycle {
private final static Method creatingParentContainersIfNeeded;
static {
AtomicReference<Method> method = new AtomicReference<>();
try {
ReflectionUtils.doWithMethods(ExistsBuilder.class, m -> {
method.set(m);
}, m -> {
return "creatingParentContainersIfNeeded".equals(m.getName()) && m.getParameterCount() == 0;
});
}
catch (Exception e) {
throw new IllegalStateException("Cannot find ExistsBuilder.creatingParentContainersIfNeeded()", e);
}
if (method.get() == null) {
throw new IllegalStateException("Cannot find ExistsBuilder.creatingParentContainersIfNeeded()");
}
creatingParentContainersIfNeeded = method.get();
}
private final Object lifecycleMonitor = new Object();
private final CuratorFramework client;
@@ -277,9 +302,10 @@ public class ZookeeperMetadataStore implements ListenableMetadataStore, SmartLif
synchronized (this.lifecycleMonitor) {
if (!this.running) {
try {
this.client.checkExists()
.creatingParentContainersIfNeeded()
.forPath(this.root);
ExistsBuilder checkExists = this.client.checkExists();
ExistsBuilderMain builderMain = (ExistsBuilderMain) creatingParentContainersIfNeeded
.invoke(checkExists, new Object[0]);
builderMain.forPath(this.root);
this.cache = new PathChildrenCache(this.client, this.root, true);
this.cache.getListenable()