Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-3666: Revise TcpNioConnectionTests

Browse Source 
Fixes: https://github.com/spring-projects/spring-integration/issues/3666

Seems like Windows socket connect to the loopback address fails sometimes because of a bug in the implementation of OpenJDK. 

* Changing loopback addr with the actual IP addr seems to help.
* Fix `TcpNioConnectionTests.testMultiAccept()` and `testNoMultiAccept()` to rely on the ` InetAddress.getLocalHost()` 
instead of `localhost` string which has to be resolved to the address yet in the testing loop
This commit is contained in:
Artem Vozhdayenko
2022-07-08 18:26:50 +03:00
committed by GitHub
parent 2e219ffbd8
commit 64aa4d5348
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spring-integration-ip/src/test/java/org/springframework/integration/ip/tcp/connection/TcpNioConnectionTests.java
View File

@@ -34,6 +34,7 @@ import java.io.IOException;
import java.io.InputStream;
import java.lang.reflect.Method;
import java.net.ConnectException;
import java.net.InetAddress;
import java.net.ServerSocket;
import java.net.Socket;
import java.net.SocketTimeoutException;
@@ -63,7 +64,6 @@ import javax.net.SocketFactory;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestInfo;
import org.junit.jupiter.api.condition.DisabledIfEnvironmentVariable;
@@ -839,13 +839,11 @@ public class TcpNioConnectionTests {
}
@Test
@Disabled("Until https://github.com/spring-projects/spring-integration/issues/3666")
public void testMultiAccept() throws InterruptedException, IOException {
testMulti(true);
}
@Test
@Disabled("Until https://github.com/spring-projects/spring-integration/issues/3666")
public void testNoMultiAccept() throws InterruptedException, IOException {
testMulti(false);
}
@@ -874,8 +872,9 @@ public class TcpNioConnectionTests {
server.afterPropertiesSet();
server.start();
assertThat(serverReadyLatch.await(10, TimeUnit.SECONDS)).isTrue();
InetAddress localHost = InetAddress.getLocalHost();
for (int i = 0; i < 10; i++) {
Socket socket = SocketFactory.getDefault().createSocket("localhost", server.getPort());
Socket socket = SocketFactory.getDefault().createSocket(localHost, server.getPort());
socket.getOutputStream().write("foo\r\n".getBytes());
sockets.add(socket);
}