INT-1433 the issue was fixed by Josh, just added tests to validate the functionality

spring-integration-sftp/src/test/java/org/springframework/integration/sftp/impl/SftpInboundRemoteFileSystemSynchronizerTests.java

@@ -0,0 +1,95 @@
+/**
+ * 
+ */
+package org.springframework.integration.sftp.impl;
+
+import static junit.framework.Assert.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.lang.reflect.Method;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.springframework.core.io.FileSystemResource;
+import org.springframework.core.io.Resource;
+import org.springframework.integration.file.AbstractInboundRemoteFileSystemSychronizer.EntryAcknowledgmentStrategy;
+import org.springframework.integration.sftp.SftpSession;
+import org.springframework.util.ReflectionUtils;
+
+import com.jcraft.jsch.ChannelSftp;
+import com.jcraft.jsch.ChannelSftp.LsEntry;
+
+/**
+ * @author ozhurakousky
+ *
+ */
+public class SftpInboundRemoteFileSystemSynchronizerTests {
+	@Before
+	public void prepare() throws Exception{
+		File foo = new File("target/foo.txt");
+		if (foo.exists()){
+			foo.delete();
+		}
+		File bar = new File("target/bar.txt");
+		if (bar.exists()){
+			bar.delete();
+		}
+		if (!foo.createNewFile()){
+			throw new IOException("Can not create test file 'foo.txt' in the 'temp' directory");
+		}
+		foo.deleteOnExit();
+		bar.deleteOnExit();
+	}
+	
+	/**
+	 * Asserts that if local file with the name provided exists, then this method 
+	 * will return 'true', although no copy will be performed. Just a pass through.
+	 * @throws Exception
+	 */
+	@Test
+	public void testCopyAndRenameWhenLocalFileExists() throws Exception {
+		SftpInboundRemoteFileSystemSynchronizer synchronizer = new SftpInboundRemoteFileSystemSynchronizer();
+		Method method = 
+			ReflectionUtils.findMethod(synchronizer.getClass(), "copyFromRemoteToLocalDirectory", SftpSession.class, LsEntry.class, Resource.class);
+		method.setAccessible(true);
+		SftpSession session = mock(SftpSession.class);
+		LsEntry entry = mock(LsEntry.class);
+		when(entry.getFilename()).thenReturn("foo.txt");
+		Resource localDir = new FileSystemResource(new File("target"));
+		boolean success = (Boolean) method.invoke(synchronizer, session, entry, localDir);
+		assertTrue(success);
+	}
+	/**
+	 * Asserts that if local file with the name provided doesn't exists, then this method 
+	 * will perfrom copy file and cleanup of the open resource INT-1433, meaning
+	 * it should not result in exception.
+	 * 
+	 * @throws Exception
+	 */
+	@Test
+	public void testCopyAndRenameWhenLocalFileDoesntExist() throws Exception {
+		SftpInboundRemoteFileSystemSynchronizer synchronizer = new SftpInboundRemoteFileSystemSynchronizer();
+		synchronizer.setEntryAcknowledgmentStrategy(mock(EntryAcknowledgmentStrategy.class));
+		Method method = 
+			ReflectionUtils.findMethod(synchronizer.getClass(), "copyFromRemoteToLocalDirectory", SftpSession.class, LsEntry.class, Resource.class);
+		method.setAccessible(true);
+		SftpSession session = mock(SftpSession.class);
+		ChannelSftp channelSftp = mock(ChannelSftp.class);
+		when(session.getChannel()).thenReturn(channelSftp);
+		File originalFile = new File("pom.xml");
+		when(channelSftp.get("null/bar.txt")).thenReturn(new FileInputStream(originalFile));
+		LsEntry entry = mock(LsEntry.class);
+		when(entry.getFilename()).thenReturn("bar.txt");
+		Resource localDir = new FileSystemResource(new File("target"));
+		boolean success = (Boolean) method.invoke(synchronizer, session, entry, localDir);
+		assertTrue(success);
+		File file = new File("target/bar.txt");
+		assertTrue(file.exists());
+		assertTrue(file.length() == originalFile.length());
+	}
+}