Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sonar Fixes

Browse Source 
https://sonar.spring.io/component_issues/index?id=org.springframework.integration%3Aspring-integration%3Amaster#resolved=false|severities=CRITICAL

Fix the only 2 code smells that Sonar deems "critical".
This commit is contained in:
Gary Russell
2017-01-11 09:53:27 -05:00
committed by Artem Bilan
parent 4c462a8972
commit c8c8160e2d
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-integration-file/src/main/java/org/springframework/integration/file/tail/OSDelegatingFileTailingMessageProducer.java
View File

@@ -188,8 +188,8 @@ public class OSDelegatingFileTailingMessageProducer extends FileTailingMessagePr
} }
return; return;
} }
final BufferedReader errorReader = new BufferedReader(new InputStreamReader(process.getErrorStream()));
this.getTaskExecutor().execute(() -> { this.getTaskExecutor().execute(() -> {
BufferedReader errorReader = new BufferedReader(new InputStreamReader(process.getErrorStream()));
String statusMessage; String statusMessage;
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.debug("Reading stderr"); logger.debug("Reading stderr");

3
spring-integration-test/src/main/java/org/springframework/integration/test/mail/TestMailServer.java
View File

@@ -97,6 +97,9 @@ public class TestMailServer {
write("220 foo SMTP"); write("220 foo SMTP");
while (!socket.isClosed()) { while (!socket.isClosed()) {
String line = reader.readLine(); String line = reader.readLine();
if (line == null) {
break;
}
if (line.contains("EHLO")) { if (line.contains("EHLO")) {
write("250-foo hello [0,0,0,0], foo"); write("250-foo hello [0,0,0,0], foo");
write("250-AUTH LOGIN PLAIN"); write("250-AUTH LOGIN PLAIN");