Spring/spring-integration
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Sonar smells in JpaExecutor

Browse Source
This commit is contained in:
Artem Bilan
2019-08-31 18:18:20 -04:00
parent 3dc0fb5980
commit fd7e7dbaf3
1 changed files with 21 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
spring-integration-jpa/src/main/java/org/springframework/integration/jpa/core/JpaExecutor.java
View File

@@ -440,21 +440,25 @@ public class JpaExecutor implements InitializingBean, BeanFactoryAware {
return this.jpaOperations.executeUpdateWithNamedQuery(this.namedQuery, paramSource);
}
else {
switch (this.persistMode) {
case PERSIST:
this.jpaOperations.persist(message.getPayload(), this.flushSize, this.clearOnFlush);
return message.getPayload();
case MERGE:
return this.jpaOperations.merge(message.getPayload(), this.flushSize, this.clearOnFlush);
case DELETE:
this.jpaOperations.delete(message.getPayload());
if (this.flush) {
this.jpaOperations.flush();
}
return message.getPayload();
default:
throw new IllegalStateException("Unsupported PersistMode: " + this.persistMode.name());
}
return executeOutboundJpaOperationOnPersistentMode(message);
}
}
private Object executeOutboundJpaOperationOnPersistentMode(Message<?> message) {
switch (this.persistMode) {
case PERSIST:
this.jpaOperations.persist(message.getPayload(), this.flushSize, this.clearOnFlush);
return message.getPayload();
case MERGE:
return this.jpaOperations.merge(message.getPayload(), this.flushSize, this.clearOnFlush);
case DELETE:
this.jpaOperations.delete(message.getPayload());
if (this.flush) {
this.jpaOperations.flush();
}
return message.getPayload();
default:
throw new IllegalStateException("Unsupported PersistMode: " + this.persistMode.name());
}
}
@@ -591,7 +595,8 @@ public class JpaExecutor implements InitializingBean, BeanFactoryAware {
int evaluatedResult = 0;
if (expression != null) {
Object evaluationResult = expression.getValue(this.evaluationContext, requestMessage); // NOSONAR can be null
Object evaluationResult = expression.getValue(this.evaluationContext, requestMessage); // NOSONAR can be
// null
if (evaluationResult != null) {
if (evaluationResult instanceof Number) {
evaluatedResult = ((Number) evaluationResult).intValue();