INT-3280 Fix SFTP Class Tangle

JIRA: https://jira.springsource.org/browse/INT-3280
This commit is contained in:
Gary Russell
2014-01-29 17:46:06 -05:00
committed by Artem Bilan
parent 1f45e00cc3
commit ff90daf575
3 changed files with 59 additions and 37 deletions

View File

@@ -17,7 +17,6 @@
package org.springframework.integration.sftp.session;
import java.util.Properties;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.locks.ReentrantReadWriteLock;
import org.springframework.beans.factory.BeanCreationException;
@@ -436,38 +435,4 @@ public class DefaultSftpSessionFactory implements SessionFactory<LsEntry>, Share
}
}
/**
* A wrapper for a JSch session that maintains a channel count and
* physically disconnects when the last channel is closed.
*
*/
public class JSchSessionWrapper {
private final com.jcraft.jsch.Session session;
private final AtomicInteger channels = new AtomicInteger();
JSchSessionWrapper(com.jcraft.jsch.Session session) {
this.session = session;
}
public void addChannel() {
this.channels.incrementAndGet();
}
public void close() {
if (channels.decrementAndGet() <= 0) {
this.session.disconnect();
}
}
public final com.jcraft.jsch.Session getSession() {
return session;
}
public boolean isConnected() {
return session.isConnected();
}
}
}

View File

@@ -0,0 +1,58 @@
/*
* Copyright 2014 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.integration.sftp.session;
import java.util.concurrent.atomic.AtomicInteger;
import com.jcraft.jsch.Session;
/**
* A wrapper for a JSch session that maintains a channel count and
* physically disconnects when the last channel is closed.
*
* @author Gary Russell
* @since 3.0
*
*/
class JSchSessionWrapper {
private final Session session;
private final AtomicInteger channels = new AtomicInteger();
JSchSessionWrapper(Session session) {
this.session = session;
}
public void addChannel() {
this.channels.incrementAndGet();
}
public void close() {
if (channels.decrementAndGet() <= 0) {
this.session.disconnect();
}
}
public final Session getSession() {
return session;
}
public boolean isConnected() {
return session.isConnected();
}
}

View File

@@ -28,7 +28,6 @@ import org.apache.commons.logging.LogFactory;
import org.springframework.core.NestedIOException;
import org.springframework.integration.file.remote.session.Session;
import org.springframework.integration.sftp.session.DefaultSftpSessionFactory.JSchSessionWrapper;
import org.springframework.util.Assert;
import org.springframework.util.FileCopyUtils;
@@ -67,7 +66,7 @@ class SftpSession implements Session<LsEntry> {
this.wrapper = null;
}
public SftpSession(DefaultSftpSessionFactory.JSchSessionWrapper wrapper) {
public SftpSession(JSchSessionWrapper wrapper) {
Assert.notNull(wrapper, "wrapper must not be null");
this.jschSession = wrapper.getSession();
this.wrapper = wrapper;