Spring/spring-kafka
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-3779: Fix KafkaTemplate from hiding error when starting observation

Browse Source 
Fixes: #3779

This fixes that exceptions thrown from `observation.start()` are hidden by `KafkaTemplate` throwing a new exception due to registering observation error without successfully starting the observation.

Signed-off-by: Christian Fredriksson <christian.fredriksson.2@volvocars.com>

**Auto-cherry-pick to `3.3.x` & `3.2.x`**
This commit is contained in:
Christian Fredriksson
2025-03-05 15:06:43 +01:00
committed by GitHub
parent cbbd1d45fe
commit bdd1fd3556
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-kafka/src/main/java/org/springframework/kafka/core/KafkaTemplate.java
View File

@@ -805,8 +805,8 @@ public class KafkaTemplate<K, V> implements KafkaOperations<K, V>, ApplicationCo
this.observationConvention, DefaultKafkaTemplateObservationConvention.INSTANCE,
() -> new KafkaRecordSenderContext(producerRecord, this.beanName, this::clusterId),
this.observationRegistry);
observation.start();
try {
observation.start();
try (Observation.Scope ignored = observation.openScope()) {
return doSend(producerRecord, observation);
}