GH-401: Add API to access consumer metrics
Fix spring-projects/spring-kafka#401
**Cherry-pick to 1.3.x**
Polish javadoc and remove dependency to jdk 8.
Return always return unmodifiable collections from metrics()
* Polishing JavaDocs
* Add author
* Mention the new feature in the Docs
(cherry picked from commit 1945f29)
This commit is contained in:
committed by
Artem Bilan
parent
ab31a11558
commit
d545fe5061
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2015-2016 the original author or authors.
|
||||
* Copyright 2015-2017 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -19,9 +19,14 @@ package org.springframework.kafka.listener;
|
||||
import java.util.ArrayList;
|
||||
import java.util.Arrays;
|
||||
import java.util.Collections;
|
||||
import java.util.HashMap;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
import java.util.concurrent.atomic.AtomicInteger;
|
||||
|
||||
import org.apache.kafka.common.Metric;
|
||||
import org.apache.kafka.common.MetricName;
|
||||
|
||||
import org.springframework.kafka.core.ConsumerFactory;
|
||||
import org.springframework.kafka.listener.config.ContainerProperties;
|
||||
import org.springframework.kafka.support.TopicPartitionInitialOffset;
|
||||
@@ -42,6 +47,7 @@ import org.springframework.util.Assert;
|
||||
* @author Murali Reddy
|
||||
* @author Jerome Mirc
|
||||
* @author Artem Bilan
|
||||
* @author Vladimir Tsanev
|
||||
*/
|
||||
public class ConcurrentMessageListenerContainer<K, V> extends AbstractMessageListenerContainer<K, V> {
|
||||
|
||||
@@ -89,6 +95,15 @@ public class ConcurrentMessageListenerContainer<K, V> extends AbstractMessageLis
|
||||
return Collections.unmodifiableList(this.containers);
|
||||
}
|
||||
|
||||
@Override
|
||||
public Map<String, Map<MetricName, ? extends Metric>> metrics() {
|
||||
Map<String, Map<MetricName, ? extends Metric>> metrics = new HashMap<>();
|
||||
for (KafkaMessageListenerContainer<K, V> container : this.containers) {
|
||||
metrics.putAll(container.metrics());
|
||||
}
|
||||
return Collections.unmodifiableMap(metrics);
|
||||
}
|
||||
|
||||
/*
|
||||
* Under lifecycle lock.
|
||||
*/
|
||||
|
||||
@@ -41,6 +41,8 @@ import org.apache.kafka.clients.consumer.NoOffsetForPartitionException;
|
||||
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
|
||||
import org.apache.kafka.clients.consumer.OffsetCommitCallback;
|
||||
import org.apache.kafka.clients.producer.Producer;
|
||||
import org.apache.kafka.common.Metric;
|
||||
import org.apache.kafka.common.MetricName;
|
||||
import org.apache.kafka.common.TopicPartition;
|
||||
import org.apache.kafka.common.errors.WakeupException;
|
||||
|
||||
@@ -80,6 +82,7 @@ import org.springframework.util.concurrent.ListenableFutureCallback;
|
||||
* @author Martin Dam
|
||||
* @author Artem Bilan
|
||||
* @author Loic Talhouarne
|
||||
* @author Vladimir Tsanev
|
||||
*/
|
||||
public class KafkaMessageListenerContainer<K, V> extends AbstractMessageListenerContainer<K, V> {
|
||||
|
||||
@@ -155,6 +158,20 @@ public class KafkaMessageListenerContainer<K, V> extends AbstractMessageListener
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public Map<String, Map<MetricName, ? extends Metric>> metrics() {
|
||||
ListenerConsumer listenerConsumer = this.listenerConsumer;
|
||||
if (listenerConsumer != null) {
|
||||
Map<MetricName, ? extends Metric> metrics = listenerConsumer.consumer.metrics();
|
||||
Iterator<MetricName> metricIterator = metrics.keySet().iterator();
|
||||
if (metricIterator.hasNext()) {
|
||||
String clientId = metricIterator.next().tags().get("client-id");
|
||||
return Collections.singletonMap(clientId, metrics);
|
||||
}
|
||||
}
|
||||
return Collections.emptyMap();
|
||||
}
|
||||
|
||||
@Override
|
||||
protected void doStart() {
|
||||
if (isRunning()) {
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2016 the original author or authors.
|
||||
* Copyright 2016-2017 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -16,6 +16,11 @@
|
||||
|
||||
package org.springframework.kafka.listener;
|
||||
|
||||
import java.util.Map;
|
||||
|
||||
import org.apache.kafka.common.Metric;
|
||||
import org.apache.kafka.common.MetricName;
|
||||
|
||||
import org.springframework.context.SmartLifecycle;
|
||||
|
||||
/**
|
||||
@@ -24,6 +29,7 @@ import org.springframework.context.SmartLifecycle;
|
||||
*
|
||||
* @author Stephane Nicoll
|
||||
* @author Gary Russell
|
||||
* @author Vladimir Tsanev
|
||||
*/
|
||||
public interface MessageListenerContainer extends SmartLifecycle {
|
||||
|
||||
@@ -34,4 +40,12 @@ public interface MessageListenerContainer extends SmartLifecycle {
|
||||
*/
|
||||
void setupMessageListener(Object messageListener);
|
||||
|
||||
/**
|
||||
* Return metrics kept by this container's consumer(s), grouped by {@code client-id}.
|
||||
* @return the consumer(s) metrics grouped by {@code client-id}
|
||||
* @since 1.3
|
||||
* @see org.apache.kafka.clients.consumer.Consumer#metrics()
|
||||
*/
|
||||
Map<String, Map<MetricName, ? extends Metric>> metrics();
|
||||
|
||||
}
|
||||
|
||||
@@ -66,6 +66,7 @@ import org.springframework.kafka.test.utils.KafkaTestUtils;
|
||||
* @author Jerome Mirc
|
||||
* @author Marius Bogoevici
|
||||
* @author Artem Yakshin
|
||||
* @author Vladimir Tsanev
|
||||
*/
|
||||
public class ConcurrentMessageListenerContainerTests {
|
||||
|
||||
@@ -139,6 +140,7 @@ public class ConcurrentMessageListenerContainerTests {
|
||||
assertThat(KafkaTestUtils.getPropertyValue(containers.get(i), "listenerConsumer.acks", Collection.class)
|
||||
.size()).isEqualTo(0);
|
||||
}
|
||||
assertThat(container.metrics()).isNotNull();
|
||||
container.stop();
|
||||
this.logger.info("Stop auto");
|
||||
}
|
||||
|
||||
@@ -417,6 +417,10 @@ each container will get one partition.
|
||||
NOTE: The `client.id` property (if set) will be appended with `-n` where `n` is the consumer instance according to the concurrency.
|
||||
This is required to provide unique names for MBeans when JMX is enabled.
|
||||
|
||||
Starting with _version 1.3_, the `MessageListenerContainer` provides an access to the metrics of the underlying `KafkaConsumer`.
|
||||
In case of `ConcurrentMessageListenerContainer` the `metrics()` method returns the metrics for all the target `KafkaMessageListenerContainer` instances.
|
||||
The metrics are grouped into the `Map<MetricName, ? extends Metric>` by the `client-id` provided for the underlying `KafkaConsumer`.
|
||||
|
||||
[[committing-offsets]]
|
||||
====== Committing Offsets
|
||||
|
||||
|
||||
Reference in New Issue
Block a user