Spring/spring-kafka
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-3693: Remove outdated DLT Topic Suffix references from Javadoc, reference doc and code sample. (#3831)

Browse Source 
Fixes: #3693

Issue link: https://github.com/spring-projects/spring-kafka/issues/3693

**Auto-cherry-pick to `3.3.x`**

Signed-off-by: Alexis SEGURA <alex.segura06@gmail.com>
Co-authored-by: Alexis SEGURA <alexis.segura@akt.io>
This commit is contained in:
Alexis SEGURA
2025-04-14 17:41:13 +02:00
committed by GitHub
parent 9db48fc9d2
commit e2a39cd580
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
samples/sample-01/src/main/java/com/example/Application.java
View File

@@ -79,7 +79,7 @@ public class Application {
this.exec.execute(() -> System.out.println("Hit Enter to terminate..."));
}
@KafkaListener(id = "dltGroup", topics = "topic1.DLT")
@KafkaListener(id = "dltGroup", topics = "topic1-dlt")
public void dltListen(byte[] in) {
logger.info("Received from DLT: " + new String(in));
this.exec.execute(() -> System.out.println("Hit Enter to terminate..."));
@@ -92,7 +92,7 @@ public class Application {
@Bean
public NewTopic dlt() {
return new NewTopic("topic1.DLT", 1, (short) 1);
return new NewTopic("topic1-dlt", 1, (short) 1);
}
@Bean

2
spring-kafka-docs/src/main/antora/modules/ROOT/pages/kafka/annotation-error-handling.adoc
View File

@@ -743,7 +743,7 @@ public ErrorHandler eh(KafkaOperations<String, String> template) {
retries.value()[0]++;
}
return retries.value()[0] > 5
? new TopicPartition("topic.DLT", rec.partition())
? new TopicPartition("topic-dlt", rec.partition())
: new TopicPartition("topic", rec.partition());
}), new FixedBackOff(0L, 0L));
}

4
spring-kafka/src/main/java/org/springframework/kafka/listener/DeadLetterPublishingRecoverer.java
View File

@@ -140,7 +140,7 @@ public class DeadLetterPublishingRecoverer extends ExceptionClassifier implement
/**
* Create an instance with the provided template and a default destination resolving
* function that returns a TopicPartition based on the original topic (appended with ".DLT")
* function that returns a TopicPartition based on the original topic (appended with "-dlt")
* from the failed record, and the same partition as the failed record. Therefore the
* dead-letter topic must have at least as many partitions as the original topic.
* @param template the {@link KafkaOperations} to use for publishing.
@@ -165,7 +165,7 @@ public class DeadLetterPublishingRecoverer extends ExceptionClassifier implement
/**
* Create an instance with the provided templates and a default destination resolving
* function that returns a TopicPartition based on the original topic (appended with
* ".DLT") from the failed record, and the same partition as the failed record.
* "-dlt") from the failed record, and the same partition as the failed record.
* Therefore the dead-letter topic must have at least as many partitions as the
* original topic. The templates map keys are classes and the value the corresponding
* template to use for objects (producer record values) of that type. A