GH-646: Avoid sync when no transaction

2018-04-13 16:22:28 -04:00
parent 42e2d01026
commit f715bbef8b
1 changed files with 7 additions and 3 deletions
--- a/spring-kafka/src/main/java/org/springframework/kafka/core/DefaultKafkaProducerFactory.java
+++ b/spring-kafka/src/main/java/org/springframework/kafka/core/DefaultKafkaProducerFactory.java
@@ -302,9 +302,13 @@ public class DefaultKafkaProducerFactory<K, V> implements ProducerFactory<K, V>,
 		}

 		@Override
-		public synchronized void close() {
-			if (this.cache != null && !this.cache.contains(this)) {
-				this.cache.offer(this);
+		public void close() {
+			if (this.cache != null) {
+				synchronized (this) {
+					if (!this.cache.contains(this)) {
+						this.cache.offer(this);
+					}
+				}
 			}
 		}