Fix Package Tangle

The introduction of `KafkaStreamsConfiguration` introduced a tangle
between `core` and `config`.

Move the `StreamsBuilderFactoryBean` to `config`.

* Polishing - PR Comments
This commit is contained in:
Gary Russell
2018-09-11 14:53:57 -04:00
committed by Artem Bilan
parent 7fdc4415e7
commit fd3efb7a4a
10 changed files with 13 additions and 12 deletions

View File

@@ -23,7 +23,7 @@ import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
import org.springframework.context.annotation.Import;
import org.springframework.kafka.core.StreamsBuilderFactoryBean;
import org.springframework.kafka.config.StreamsBuilderFactoryBean;
/**
* Enable default Kafka Streams components. To be used on

View File

@@ -24,7 +24,7 @@ import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.kafka.config.KafkaStreamsConfiguration;
import org.springframework.kafka.core.StreamsBuilderFactoryBean;
import org.springframework.kafka.config.StreamsBuilderFactoryBean;
/**
* {@code @Configuration} class that registers a {@link StreamsBuilderFactoryBean}

View File

@@ -14,7 +14,7 @@
* limitations under the License.
*/
package org.springframework.kafka.core;
package org.springframework.kafka.config;
import java.util.ArrayList;
import java.util.List;

View File

@@ -14,7 +14,7 @@
* limitations under the License.
*/
package org.springframework.kafka.core;
package org.springframework.kafka.config;
import org.apache.kafka.streams.KafkaStreams;

View File

@@ -14,7 +14,7 @@
* limitations under the License.
*/
package org.springframework.kafka.core;
package org.springframework.kafka.config;
import java.util.Map;
import java.util.Properties;
@@ -31,7 +31,7 @@ import org.apache.kafka.streams.processor.internals.DefaultKafkaClientSupplier;
import org.springframework.beans.factory.config.AbstractFactoryBean;
import org.springframework.context.SmartLifecycle;
import org.springframework.kafka.KafkaException;
import org.springframework.kafka.config.KafkaStreamsConfiguration;
import org.springframework.kafka.core.CleanupConfig;
import org.springframework.lang.Nullable;
import org.springframework.util.Assert;

View File

@@ -14,7 +14,7 @@
* limitations under the License.
*/
package org.springframework.kafka.core;
package org.springframework.kafka.config;
import static org.assertj.core.api.Assertions.assertThat;
@@ -32,7 +32,6 @@ import org.springframework.context.annotation.Configuration;
import org.springframework.kafka.annotation.EnableKafka;
import org.springframework.kafka.annotation.EnableKafkaStreams;
import org.springframework.kafka.annotation.KafkaStreamsDefaultConfiguration;
import org.springframework.kafka.config.KafkaStreamsConfiguration;
import org.springframework.kafka.test.EmbeddedKafkaBroker;
import org.springframework.kafka.test.context.EmbeddedKafka;
import org.springframework.test.annotation.DirtiesContext;

View File

@@ -14,7 +14,7 @@
* limitations under the License.
*/
package org.springframework.kafka.core;
package org.springframework.kafka.config;
import static org.assertj.core.api.Assertions.assertThat;
@@ -37,7 +37,7 @@ import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.kafka.annotation.EnableKafkaStreams;
import org.springframework.kafka.annotation.KafkaStreamsDefaultConfiguration;
import org.springframework.kafka.config.KafkaStreamsConfiguration;
import org.springframework.kafka.core.CleanupConfig;
import org.springframework.kafka.test.EmbeddedKafkaBroker;
import org.springframework.kafka.test.context.EmbeddedKafka;
import org.springframework.test.annotation.DirtiesContext;

View File

@@ -14,7 +14,7 @@
* limitations under the License.
*/
package org.springframework.kafka.core;
package org.springframework.kafka.config;
import static org.assertj.core.api.Assertions.assertThat;

View File

@@ -54,12 +54,12 @@ import org.springframework.kafka.annotation.KafkaStreamsDefaultConfiguration;
import org.springframework.kafka.config.ConcurrentKafkaListenerContainerFactory;
import org.springframework.kafka.config.KafkaListenerContainerFactory;
import org.springframework.kafka.config.KafkaStreamsConfiguration;
import org.springframework.kafka.config.StreamsBuilderFactoryBean;
import org.springframework.kafka.core.ConsumerFactory;
import org.springframework.kafka.core.DefaultKafkaConsumerFactory;
import org.springframework.kafka.core.DefaultKafkaProducerFactory;
import org.springframework.kafka.core.KafkaTemplate;
import org.springframework.kafka.core.ProducerFactory;
import org.springframework.kafka.core.StreamsBuilderFactoryBean;
import org.springframework.kafka.listener.ConcurrentMessageListenerContainer;
import org.springframework.kafka.support.serializer.JsonSerde;
import org.springframework.kafka.test.EmbeddedKafkaBroker;

View File

@@ -78,6 +78,8 @@ See <<serdes>> for more information.
The streams configuration bean must now be a simple `Properties` object instead of a `StreamsConfig`.
The `StreamsBuilderFactoryBean` has been moved from package `...core` to `...config`.
See <<kafka-streams>> for more information.