Spring/spring-modulith
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-1068 - Switch to simple event type name for automatically created counters.

Browse Source
This commit is contained in:
Oliver Drotbohm
2025-02-23 09:48:05 +01:00
parent 78991f4723
commit 20f07b7936
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-modulith-observability/src/main/java/org/springframework/modulith/observability/support/CrossModuleEventCounterFactory.java
View File

@@ -94,7 +94,7 @@ public class CrossModuleEventCounterFactory implements ModulithEventMetrics {
private static final BiConsumer<Object, Builder> NO_OP = (event, builder) -> {};
private static final Function<Object, Builder> DEFAULT_FACTORY = event -> Counter
.builder(event.getClass().getName());
.builder(event.getClass().getSimpleName());
public static final ModulithMetricsCustomizer DEFAULT = new ModulithMetricsCustomizer(Object.class, NO_OP);

3
spring-modulith-observability/src/test/java/org/springframework/modulith/observability/support/CrossModuleEventCounterFactoryUnitTests.java
View File

@@ -25,7 +25,6 @@ import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
import java.util.function.Consumer;
import org.junit.jupiter.api.Test;
import org.springframework.modulith.observability.support.CrossModuleEventCounterFactory;
/**
* Unit tests for {@link CrossModuleEventCounterFactory}.
@@ -43,7 +42,7 @@ class CrossModuleEventCounterFactoryUnitTests {
factory.customize(SampleEvent.class, (__, builder) -> builder.tag("key", "value"));
assertCounter(new SampleEvent(), it -> {
assertThat(it.getName()).isEqualTo(SampleEvent.class.getName());
assertThat(it.getName()).isEqualTo(SampleEvent.class.getSimpleName());
assertThat(it.getTag("key")).isNotNull();
});
}