Spring/spring-modulith
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-483 - Let CompletionRegisteringAdvisor forward EventExternalized event.

Browse Source
This commit is contained in:
Oliver Drotbohm
2024-01-21 17:56:53 +01:00
parent 6770526cac
commit c5f73e675d
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spring-modulith-events/spring-modulith-events-core/src/main/java/org/springframework/modulith/events/support/CompletionRegisteringAdvisor.java
View File

@@ -175,7 +175,10 @@ public class CompletionRegisteringAdvisor extends AbstractPointcutAdvisor {
if (result instanceof CompletableFuture<?> future) {
return future
.thenAccept(it -> markCompleted(method, argument))
.thenApply(it -> {
markCompleted(method, argument);
return it;
})
.exceptionallyCompose(it -> {
handleFailure(method, it);
return CompletableFuture.failedFuture(it);

8
spring-modulith-events/spring-modulith-events-core/src/test/java/org/springframework/modulith/events/support/CompletionRegisteringAdvisorUnitTests.java
View File

@@ -89,6 +89,14 @@ class CompletionRegisteringAdvisorUnitTests {
verify(registry).markCompleted(any(), any());
}
@Test // GH-483
void exposesResultForCompletableFuture() throws Exception {
CompletableFuture<?> future = createProxyFor(bean).asyncWithResult(false);
assertThat(future.get()).isNotNull();
}
private void assertCompletion(BiConsumer<SomeEventListener, Object> consumer) {
assertCompletion(consumer, true);
}