Spring/spring-modulith
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-1160 - Improve lookup of event publications in progress.

Browse Source 
Instead of iterating over all publications currently in progress we now use a map to look them up by key.

Baseline
--------
Benchmark                        Mode  Cnt        Score      Error  Units
….inProgressPublicationsAccess  thrpt   50      312,155 ±    7,428  ops/s

Fixed
-----
Benchmark                        Mode  Cnt        Score      Error  Units
….inProgressPublicationsAccess  thrpt   50  2328732,504 ± 7809,092  ops/s
This commit is contained in:
Oliver Drotbohm
2025-04-18 12:56:52 +02:00
parent cb8e82ac38
commit c8cdb0271f
1 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
spring-modulith-events/spring-modulith-events-core/src/main/java/org/springframework/modulith/events/core/DefaultEventPublicationRegistry.java
View File

@@ -19,10 +19,9 @@ import java.time.Clock;
import java.time.Duration;
import java.time.Instant;
import java.util.Collection;
import java.util.HashSet;
import java.util.Iterator;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Consumer;
import java.util.function.Predicate;
@@ -296,7 +295,7 @@ public class DefaultEventPublicationRegistry
*/
static class PublicationsInProgress implements Iterable<TargetEventPublication> {
private final Set<TargetEventPublication> publications = ConcurrentHashMap.newKeySet();
private final Map<Key, TargetEventPublication> publications = new ConcurrentHashMap<>();
/**
* Registers the given {@link TargetEventPublication} as currently processed.
@@ -308,7 +307,7 @@ public class DefaultEventPublicationRegistry
Assert.notNull(publication, "TargetEventPublication must not be null!");
publications.add(publication);
publications.put(new Key(publication), publication);
return publication;
}
@@ -325,8 +324,7 @@ public class DefaultEventPublicationRegistry
Assert.notNull(event, "Event must not be null!");
Assert.notNull(identifier, "PublicationTargetIdentifier must not be null!");
getPublication(event, identifier)
.ifPresent(publications::remove);
publications.remove(new Key(event, identifier));
}
/**
@@ -338,7 +336,7 @@ public class DefaultEventPublicationRegistry
Assert.notNull(publication, "TargetEventPublication must not be null!");
publications.remove(publication);
publications.remove(new Key(publication));
}
/**
@@ -354,9 +352,7 @@ public class DefaultEventPublicationRegistry
Assert.notNull(event, "Event must not be null!");
Assert.notNull(identifier, "PublicationTargetIdentifier must not be null!");
return publications.stream()
.filter(it -> it.isAssociatedWith(event, identifier))
.findFirst();
return Optional.ofNullable(publications.get(new Key(event, identifier)));
}
/*
@@ -365,7 +361,14 @@ public class DefaultEventPublicationRegistry
*/
@Override
public Iterator<TargetEventPublication> iterator() {
return new HashSet<>(publications).iterator();
return publications.values().iterator();
}
private record Key(Object event, PublicationTargetIdentifier identifier) {
public Key(TargetEventPublication publication) {
this(publication.getEvent(), publication.getTargetIdentifier());
}
}
}
}