Spring/spring-modulith
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-252 - Avoid premature initialization of SpringModulithRuntimeAutoConfiguration.

Browse Source 
Bean declarations are now entirely static.
This commit is contained in:
Oliver Drotbohm
2023-08-01 23:35:19 +02:00
parent 04187a1706
commit d665161c37
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spring-modulith-runtime/src/main/java/org/springframework/modulith/runtime/autoconfigure/SpringModulithRuntimeAutoConfiguration.java
View File

@@ -42,8 +42,8 @@ import org.springframework.modulith.runtime.ApplicationRuntime;
import org.springframework.util.Assert;
/**
* Auto-configuration to register a {@link SpringBootApplicationRuntime} and {@link ApplicationModulesRuntime} as Spring
* Bean.
* Auto-configuration to register a {@link SpringBootApplicationRuntime}, a {@link ApplicationModulesRuntime} and an
* {@link ApplicationListener} to invoke all {@link ApplicationModuleInitializer}s as Spring Bean.
*
* @author Oliver Drotbohm
*/
@@ -51,29 +51,31 @@ import org.springframework.util.Assert;
class SpringModulithRuntimeAutoConfiguration {
private static final Logger LOGGER = LoggerFactory.getLogger(SpringModulithRuntimeAutoConfiguration.class);
private final AsyncTaskExecutor executor = new SimpleAsyncTaskExecutor();
private static final AsyncTaskExecutor EXECUTOR = new SimpleAsyncTaskExecutor();
@Bean
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
@ConditionalOnMissingBean(ApplicationRuntime.class)
SpringBootApplicationRuntime modulithsApplicationRuntime(ApplicationContext context) {
static SpringBootApplicationRuntime modulithsApplicationRuntime(ApplicationContext context) {
return new SpringBootApplicationRuntime(context);
}
@Bean
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
@ConditionalOnMissingBean
ApplicationModulesRuntime modulesRuntime(ApplicationRuntime runtime) {
static ApplicationModulesRuntime modulesRuntime(ApplicationRuntime runtime) {
var mainClass = runtime.getMainApplicationClass();
var modules = executor
var modules = EXECUTOR
.submit(() -> ApplicationModulesBootstrap.initializeApplicationModules(mainClass));
return new ApplicationModulesRuntime(toSupplier(modules), runtime);
}
@Bean
ApplicationListener<ApplicationStartedEvent> applicationModuleInitializingListener(ListableBeanFactory beanFactory) {
@Role(BeanDefinition.ROLE_INFRASTRUCTURE)
static ApplicationListener<ApplicationStartedEvent> applicationModuleInitializingListener(
ListableBeanFactory beanFactory) {
return event -> {