Spring/spring-pulsar
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polish "Respect executor set on container props"

Browse Source 
- Remove final keyword from newly added test
- Use AssertJ isSameAs for executor comparison
This commit is contained in:
Chris Bono
2025-05-06 18:31:18 -05:00
committed by Chris Bono
parent 6dcc813576
commit 984945d382
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
spring-pulsar/src/test/java/org/springframework/pulsar/config/ConcurrentPulsarListenerContainerFactoryTests.java
View File

@@ -26,7 +26,7 @@ import org.apache.pulsar.client.api.SubscriptionType;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import org.springframework.core.task.SimpleAsyncTaskExecutor;
import org.springframework.core.task.AsyncTaskExecutor;
import org.springframework.pulsar.core.PulsarConsumerFactory;
import org.springframework.pulsar.listener.PulsarContainerProperties;
@@ -144,23 +144,23 @@ class ConcurrentPulsarListenerContainerFactoryTests {
}
@Nested
class ConsumerTaskExecutor {
class ConsumerTaskExecutorFrom {
@Test
@SuppressWarnings("unchecked")
void factoryValueCopiedWhenCreatingContainer() {
final var factoryProps = new PulsarContainerProperties();
factoryProps.setConsumerTaskExecutor(new SimpleAsyncTaskExecutor());
final var containerFactory = new ConcurrentPulsarListenerContainerFactory<String>(
void factoryPropsUsedWhenSpecified() {
var factoryProps = new PulsarContainerProperties();
AsyncTaskExecutor executor = mock();
factoryProps.setConsumerTaskExecutor(executor);
var containerFactory = new ConcurrentPulsarListenerContainerFactory<String>(
mock(PulsarConsumerFactory.class), factoryProps);
final var endpoint = mock(PulsarListenerEndpoint.class);
// Mockito by default returns 0 for Integer
when(endpoint.getConcurrency()).thenReturn(null);
var endpoint = mock(PulsarListenerEndpoint.class);
when(endpoint.getConcurrency()).thenReturn(1);
final var createdContainer = containerFactory.createRegisteredContainer(endpoint);
final var containerProperties = createdContainer.getContainerProperties();
assertThat(containerProperties.getConsumerTaskExecutor()).isEqualTo(factoryProps.getConsumerTaskExecutor());
var container = containerFactory.createRegisteredContainer(endpoint);
assertThat(container.getContainerProperties())
.extracting(PulsarContainerProperties::getConsumerTaskExecutor)
.isSameAs(executor);
}
}