Spring/spring-pulsar
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove custom argument resolvers (#246)

Browse Source 
- Remove custom argument resolvers from PulsarListenerEndpointRegistrar,
  as this is an un-used feature at the moment.

- The default HandlerMethodArgumentResolver is capable of adapting the all the
  method arguments in all the PulsarListener use cases we encountered so far.
  We will add it back if custom argument resolution is necessary.
This commit is contained in:
Soby Chacko
2022-11-28 21:26:22 -05:00
committed by GitHub
parent fcc07cff84
commit edd32284d5
3 changed files with 0 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spring-pulsar-reactive/src/main/java/org/springframework/pulsar/reactive/config/annotation/ReactivePulsarListenerAnnotationBeanPostProcessor.java
View File

@@ -74,7 +74,6 @@ import org.springframework.lang.Nullable;
import org.springframework.messaging.converter.GenericMessageConverter;
import org.springframework.messaging.handler.annotation.support.DefaultMessageHandlerMethodFactory;
import org.springframework.messaging.handler.annotation.support.MessageHandlerMethodFactory;
import org.springframework.messaging.handler.invocation.HandlerMethodArgumentResolver;
import org.springframework.messaging.handler.invocation.InvocableHandlerMethod;
import org.springframework.pulsar.annotation.PulsarListenerConfigurer;
import org.springframework.pulsar.config.PulsarListenerBeanNames;
@@ -658,14 +657,6 @@ public class ReactivePulsarListenerAnnotationBeanPostProcessor<V>
this.defaultFormattingConversionService);
defaultFactory.setMessageConverter(messageConverter);
List<HandlerMethodArgumentResolver> customArgumentsResolver = new ArrayList<>(
ReactivePulsarListenerAnnotationBeanPostProcessor.this.registrar
.getCustomMethodArgumentResolvers());
// Has to be at the end - look at PayloadMethodArgumentResolver documentation
// customArgumentsResolver.add(new
// PulsarNullAwarePayloadArgumentResolver(messageConverter, validator));
defaultFactory.setCustomArgumentResolvers(customArgumentsResolver);
defaultFactory.afterPropertiesSet();
return defaultFactory;

8
spring-pulsar/src/main/java/org/springframework/pulsar/annotation/PulsarListenerAnnotationBeanPostProcessor.java
View File

@@ -75,7 +75,6 @@ import org.springframework.lang.Nullable;
import org.springframework.messaging.converter.GenericMessageConverter;
import org.springframework.messaging.handler.annotation.support.DefaultMessageHandlerMethodFactory;
import org.springframework.messaging.handler.annotation.support.MessageHandlerMethodFactory;
import org.springframework.messaging.handler.invocation.HandlerMethodArgumentResolver;
import org.springframework.messaging.handler.invocation.InvocableHandlerMethod;
import org.springframework.pulsar.config.MethodPulsarListenerEndpoint;
import org.springframework.pulsar.config.PulsarListenerBeanNames;
@@ -713,13 +712,6 @@ public class PulsarListenerAnnotationBeanPostProcessor<V>
this.defaultFormattingConversionService);
defaultFactory.setMessageConverter(messageConverter);
List<HandlerMethodArgumentResolver> customArgumentsResolver = new ArrayList<>(
PulsarListenerAnnotationBeanPostProcessor.this.registrar.getCustomMethodArgumentResolvers());
// Has to be at the end - look at PayloadMethodArgumentResolver documentation
// customArgumentsResolver.add(new
// PulsarNullAwarePayloadArgumentResolver(messageConverter, validator));
defaultFactory.setCustomArgumentResolvers(customArgumentsResolver);
defaultFactory.afterPropertiesSet();
return defaultFactory;

10
spring-pulsar/src/main/java/org/springframework/pulsar/config/PulsarListenerEndpointRegistrar.java
View File

@@ -17,8 +17,6 @@
package org.springframework.pulsar.config;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import org.springframework.beans.factory.BeanFactory;
@@ -73,14 +71,6 @@ public class PulsarListenerEndpointRegistrar implements BeanFactoryAware, Initia
return this.endpointRegistry;
}
public List<HandlerMethodArgumentResolver> getCustomMethodArgumentResolvers() {
return Collections.unmodifiableList(this.customMethodArgumentResolvers);
}
public void setCustomMethodArgumentResolvers(HandlerMethodArgumentResolver... methodArgumentResolvers) {
this.customMethodArgumentResolvers = Arrays.asList(methodArgumentResolvers);
}
public void setMessageHandlerMethodFactory(MessageHandlerMethodFactory PulsarHandlerMethodFactory) {
Assert.isNull(this.validator, "A validator cannot be provided with a custom message handler factory");
this.messageHandlerMethodFactory = PulsarHandlerMethodFactory;