Spring/spring-restdocs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Close Writers in StandardWriterResolverTests

Browse Source 
The unclosed writers were preventing clean up of the JUnit-managed
temporary directory.

See gh-959
This commit is contained in:
Andy Wilkinson
2025-06-03 17:58:13 +01:00
parent b82451e527
commit 7c7daf6c04
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spring-restdocs-core/src/test/java/org/springframework/restdocs/snippet/StandardWriterResolverTests.java
View File

@@ -78,8 +78,9 @@ class StandardWriterResolverTests {
PlaceholderResolver resolver = mock(PlaceholderResolver.class);
given(resolver.resolvePlaceholder("a")).willReturn("alpha");
given(this.placeholderResolverFactory.create(context)).willReturn(resolver);
Writer writer = this.resolver.resolve("{a}", "bravo", context);
assertSnippetLocation(writer, new File(outputDirectory, "alpha/bravo.adoc"));
try (Writer writer = this.resolver.resolve("{a}", "bravo", context)) {
assertSnippetLocation(writer, new File(outputDirectory, "alpha/bravo.adoc"));
}
}
@Test
@@ -89,8 +90,9 @@ class StandardWriterResolverTests {
PlaceholderResolver resolver = mock(PlaceholderResolver.class);
given(resolver.resolvePlaceholder("b")).willReturn("bravo");
given(this.placeholderResolverFactory.create(context)).willReturn(resolver);
Writer writer = this.resolver.resolve("alpha", "{b}", context);
assertSnippetLocation(writer, new File(outputDirectory, "alpha/bravo.adoc"));
try (Writer writer = this.resolver.resolve("alpha", "{b}", context)) {
assertSnippetLocation(writer, new File(outputDirectory, "alpha/bravo.adoc"));
}
}
private RestDocumentationContext createContext(String outputDir) {