Commit Graph

608 Commits

Author SHA1 Message Date
Andy Wilkinson
920ced0755 Preserve cookies when preprocessing a request to modify its URIs
Closes gh-523
2018-07-16 10:48:50 +01:00
Andy Wilkinson
e14bda0893 Disable interpolation of Asciidoctor path parameter table's title
Previously, when generating Asciidoctor snipppets, the title of the
path parameter table was interpolated. The title of the table is the
path including its parameters. The parameters are typically surrounded
by { and }. This is the same syntax used for attributes in
Asciidoctor. With interpolation enabled this caused Asciidoctor to
interpret the parameter as an attribute reference and attempt to
replace it. This would either result in unwanted replacement of the
parameter with the value of the attribute or it would result in a
warning about a missing attribute.

This commit surrounds the title of the table with + characters. This
disables all interpolation for the title, thereby preventing
unwanted replacement or attempted replacement of the path's
parameters.

Closes gh-527
2018-07-16 10:30:14 +01:00
Andy Wilkinson
e1948f29b1 Merge pull request #524 from Johnny Lim
* gh-524:
  Fix typo in JsonContentHandlerTests
2018-07-03 09:36:21 +01:00
Johnny Lim
ae37bb2044 Fix typo in JsonContentHandlerTests
Closes gh-524
2018-07-03 09:35:55 +01:00
Andy Wilkinson
7bde04ea46 Consider sometimes present field beneath optional array to not be missing
The changes made in 7476562d inadvertently caused a field that is
an descendant of an array and a child of an optional field to be
considered missing when its parent is only sometimes present. Due to
the parent being optional, the parent’s absence should not cause the
absent child to be considered to be missing.

Closes gh-519
2018-06-26 12:14:41 +01:00
Andy Wilkinson
20bc7b3cd8 Polish 2018-06-25 17:07:37 +01:00
Andy Wilkinson
7476562d22 Consider optional empty arrays to be absent when finding missing fields
Closes gh-519
2018-06-25 16:59:19 +01:00
Andy Wilkinson
7e49a20cb0 Merge pull request #507 from Renann Prado
* gh-507:
  Polish "Fix typo in OperationResponsePreprocessor javadoc"
  Fix typo in OperationResponsePreprocessor javadoc
2018-06-25 16:25:50 +01:00
Andy Wilkinson
c29d094f05 Polish "Fix typo in OperationResponsePreprocessor javadoc"
Closes gh-507
2018-06-25 16:25:34 +01:00
Renann Prado
94a57c33cf Fix typo in OperationResponsePreprocessor javadoc
See gh-507
2018-06-25 16:25:34 +01:00
Andy Wilkinson
86c31c96b9 Avoid duplication of parameters when POSTing form URL encoded bodies
Previously if a request body contained form URL encoded content,
parameters would be duplicated in the request body and in the
request URL in the curl, HTTPie, and HTTP request snippets.

This commit updates the affected snippets so that parameters are not
added to the URL when they will also be represented in the request
body.

Closes gh-514
2018-06-25 16:21:39 +01:00
Andy Wilkinson
1e35e8279c Polish Slate sample's README 2018-04-24 08:35:13 +01:00
Andy Wilkinson
a2b62e025a Update samples to use 1.2.5 snapshots 2018-04-04 10:55:02 +01:00
Spring Buildmaster
037d572e2c Next development version 2018-04-04 09:23:04 +00:00
Andy Wilkinson
4c6cccac24 Upgrade to REST Assured 3.0.7
Closes gh-500
2018-04-04 09:13:17 +01:00
Andy Wilkinson
39733893c1 Upgrade to Spring Framework 4.3.15
Closes gh-499
2018-04-04 09:08:05 +01:00
Andy Wilkinson
baa8e6bb90 Document an example of the operation macro's equivalent Asciidoctor
Closes gh-470
2018-03-28 10:10:10 +01:00
Andy Wilkinson
1c08000bcf Retain subsection extractor when adding field descriptors with prefix
Closes gh-480
2018-03-28 09:46:27 +01:00
Andy Wilkinson
7924d5fb01 Disable formatting of monospaced text in Asciidoctor templates
Previously, if text enclosed in ` characters contained multiple *
characters, the *s would be removed and the characters they enclosed
would become bold.

This commit escapes the text by enclosing it in + characters in
addition to the existing, enclosing ` characters. The `+text+`
arrangement retains the monospace formatting be disables any further
formatting of the text.

Closes gh-474
2018-03-27 16:08:11 +01:00
Andy Wilkinson
0b0c9e1cc4 Perform attribute substitution on operation macro's target
Closes gh-491
2018-03-27 15:24:00 +01:00
Andy Wilkinson
ecbb3a8d67 Merge pull request #477 from Pierre-Jean Vardanega
* gh-477:
  Convert query parameters list as param=1&param=2 instead of param=1,2
2018-03-27 14:26:14 +01:00
Pierre-Jean Vardanega
586de30212 Convert query parameters list as param=1&param=2 instead of param=1,2
Closes gh-477
2018-03-27 14:25:33 +01:00
Andy Wilkinson
a7e91ad63f Merge pull request #488 from Johnny Lim
* gh-488:
  Add HTTP method option unconditionally in curl command
2018-03-27 14:08:31 +01:00
Johnny Lim
da64c55fce Add HTTP method option unconditionally in curl command
Closes gh-488
2018-03-27 14:07:47 +01:00
Andy Wilkinson
95c4234c99 Format core code with Eclipse Oxygen's formatter 2018-03-27 12:53:34 +01:00
Andy Wilkinson
f651c30e03 Merge pull request #482 from bartolom
* gh-482:
  Quote cols attribute in Asciidoc table example
2018-02-19 12:37:48 +00:00
bartolom
7e3417e124 Quote cols attribute in Asciidoc table example
Closes gh-482
2018-02-19 12:36:25 +00:00
Andy Wilkinson
80bb632849 Warn against the use of org.asciidoctor.convert 1.5.6
Closes gh-438
2018-02-05 12:25:12 +00:00
Andy Wilkinson
874bfd119e Update samples to use 1.2.4 snapshots 2017-11-28 09:23:03 +00:00
Spring Buildmaster
fe9ec0ea1c Next development version 2017-11-28 09:19:01 +00:00
Andy Wilkinson
4d710d9143 Merge pull request #449 from Michael Simons
* gh-449:
  Fix name of self rel in reference documentation
2017-11-11 18:58:18 +00:00
Michael J. Simons
92b6268da4 Fix name of self rel in reference documentation
Closes gh-449
2017-11-11 18:57:42 +00:00
Andy Wilkinson
90c3549f55 Refine ordering of default, operation, and additional snippets
Previously, the ordering was:

1. Operation snippets
2. Default snippets
3. Additional snippets

This meant that any operation snippets (those specifically configured
for the documentation of the particular operation) would be
overwritten by the output of the default snippets.

This commit updates the ordering to the following:

1. Default snippets
2. Operation snippets
3. Additional snippets

Closes gh-453
2017-11-07 17:52:02 +00:00
Andy Wilkinson
abe36e3b54 Ensure that section heading appears in reference documentation
Asciidoctor appears to apply two blanks lines beneath a code block
at the end of an included file otherwise the section heading that
opens the following included file will be omitted.

Closes gh-442
2017-10-27 12:08:11 +01:00
Andy Wilkinson
473e3e1a7b Correct end tag in included source so that it matches opening tag
Closes gh-441
2017-10-23 15:47:42 +01:00
Andy Wilkinson
dfe856815d Correct section IDs so that all sections are uniquely identified
Closes gh-440
2017-10-23 15:46:42 +01:00
Andy Wilkinson
07bca1875f Replace placeholders in snippet name as well as the operation name
Previously, StandardWriterResolver only replaced placeholders in the
operation name. This meant that the name and location of generated
snippets was unnecessarily limited.

This commit makes things more flexible by updating
StandardWriterResolver to replace placeholders in the snippet name
as well.

Closes gh-403
2017-10-20 10:56:07 +01:00
Andy Wilkinson
f62b0f3ce7 Support documentation of a required field beneath an optional field
Previously, if a field nested beneath an optional field was documented
and was required, it would be identified as missing even if its
optional ancestor was missing. This made it impossible to document
required fields of an optional subsection of a payload.

This commit updates JsonContentHandler to consider a field’s ancestors
when determining if it should be reported as missing. If the field
field has an optional ancestor that is not present, the field is not
considered to be missing if it too is not present. If the field has
an optional ancestor that is present then the field is considered to
be missing if it is not present.

Closes gh-429
2017-10-20 10:05:26 +01:00
Andy Wilkinson
ead32c3f88 Merge pull request #436 from Johnny Lim
* gh-436:
  Polish tests
2017-10-20 09:57:22 +01:00
Johnny Lim
aeb12673ae Polish tests
Closes gh-436
2017-10-20 09:39:59 +01:00
Andy Wilkinson
caf01d1f21 Revert "Make sure that spring-aop is available at test runtime"
This reverts commit 26707cd7ac.

See gh-411
2017-10-13 11:42:33 +01:00
Andy Wilkinson
440997c72b Merge pull request #431 from Johnny Lim
* gh-431:
  Polish “Reuse ObjectMapper in FieldPathPayloadSubsectionExtractor”
  Reuse ObjectMapper in FieldPathPayloadSubsectionExtractor
2017-10-12 10:36:57 +01:00
Andy Wilkinson
0c8ec11c9c Polish “Reuse ObjectMapper in FieldPathPayloadSubsectionExtractor” 2017-10-12 10:36:23 +01:00
Johnny Lim
9bd9fa31dc Reuse ObjectMapper in FieldPathPayloadSubsectionExtractor
Closes gh-431
2017-10-12 10:33:40 +01:00
Andy Wilkinson
d1881c30e2 Update the samples to use the latest snapshots 2017-09-28 06:57:44 +01:00
Spring Buildmaster
f6002a00a3 Next development version 2017-09-28 05:54:30 +00:00
Andy Wilkinson
9e3a3c0536 Upgrade to latest version of JRuby to avoid problems on Windows
See https://github.com/jruby/jruby/issues/4745
2017-09-23 19:45:59 +01:00
Andy Wilkinson
47bcc45e45 Upgrade dependencies 2017-09-23 18:00:17 +01:00
Andy Wilkinson
d22dc1e211 Include filename in Content-Disposition header when available
Closes gh-425
2017-09-23 17:40:22 +01:00
Andy Wilkinson
7c6c2e7523 Polish 2017-09-23 17:20:03 +01:00