Spring/spring-retry
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix EnableRetryWithBackoffTests for possible random as 0 jitter

Browse Source 
* Some other code style refactoring for better readability and AssertJ API usage
This commit is contained in:
Artem Bilan
2024-12-13 11:09:47 -05:00
parent 87f02c2f45
commit 9c603ab338
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/test/java/org/springframework/retry/annotation/EnableRetryWithBackoffTests.java
View File

@@ -52,7 +52,7 @@ public class EnableRetryWithBackoffTests {
RandomService service = context.getBean(RandomService.class);
service.service();
List<Long> periods = context.getBean(PeriodSleeper.class).getPeriods();
assertThat(periods.get(0) > 1000).describedAs("Wrong periods: %s" + periods.toString()).isTrue();
assertThat(periods.get(0)).describedAs("Wrong periods: %s" + periods).isGreaterThan(1000);
assertThat(service.getCount()).isEqualTo(3);
context.close();
}
@@ -76,9 +76,7 @@ public class EnableRetryWithBackoffTests {
List<Long> periods = context.getBean(PeriodSleeper.class).getPeriods();
assertThat(context.getBean(PeriodSleeper.class).getPeriods().toString()).isNotEqualTo("[1000, 1100]");
assertThat(periods.get(0)).describedAs("Wrong periods: %s" + periods).isGreaterThanOrEqualTo(1000);
assertThat(periods.get(1)).describedAs("Wrong periods: %s" + periods)
.isGreaterThanOrEqualTo(1100)
.isLessThanOrEqualTo(1210);
assertThat(periods.get(1)).describedAs("Wrong periods: %s" + periods).isBetween(1100L, 1210L);
context.close();
}
@@ -90,9 +88,8 @@ public class EnableRetryWithBackoffTests {
assertThat(service.getCount()).isEqualTo(3);
List<Long> periods = context.getBean(PeriodSleeper.class).getPeriods();
assertThat(context.getBean(PeriodSleeper.class).getPeriods().toString()).isNotEqualTo("[1000, 1100]");
assertThat(periods.get(0) > 1000).describedAs("Wrong periods: %s" + periods.toString()).isTrue();
assertThat(periods.get(1) > 1100 && periods.get(1) < 1210).describedAs("Wrong periods: %s" + periods.toString())
.isTrue();
assertThat(periods.get(0)).describedAs("Wrong periods: %s" + periods).isGreaterThanOrEqualTo(1000);
assertThat(periods.get(1)).describedAs("Wrong periods: %s" + periods).isBetween(1100L, 1210L);
context.close();
}
@@ -102,7 +99,7 @@ public class EnableRetryWithBackoffTests {
protected static class TestConfiguration {
@Bean
public PeriodSleeper sleper() {
public PeriodSleeper sleeper() {
return new PeriodSleeper();
}