Spring/spring-retry
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-456: Fix EnableRetryWithBackoffTests.randomExponential() for random

Browse Source 
Fixes: #456

The random logic in the `ExponentialRandomBackOffPolicy` may end up with close to the `1`.
And after casting to `long` we got the same `1000`

* Fix test respectively to include that possibility.
This commit is contained in:
Artem Bilan
2024-07-18 10:57:09 -04:00
parent 04f12a7d96
commit a9b329af55
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/java/org/springframework/retry/annotation/EnableRetryWithBackoffTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2006-2023 the original author or authors.
* Copyright 2006-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -31,6 +31,7 @@ import static org.assertj.core.api.Assertions.assertThat;
/**
* @author Dave Syer
* @author Artem Bilan
*
*/
public class EnableRetryWithBackoffTests {
@@ -74,9 +75,10 @@ public class EnableRetryWithBackoffTests {
assertThat(service.getCount()).isEqualTo(3);
List<Long> periods = context.getBean(PeriodSleeper.class).getPeriods();
assertThat(context.getBean(PeriodSleeper.class).getPeriods().toString()).isNotEqualTo("[1000, 1100]");
assertThat(periods.get(0) > 1000).describedAs("Wrong periods: %s" + periods.toString()).isTrue();
assertThat(periods.get(1) > 1100 && periods.get(1) < 1210).describedAs("Wrong periods: %s" + periods.toString())
.isTrue();
assertThat(periods.get(0)).describedAs("Wrong periods: %s" + periods).isGreaterThanOrEqualTo(1000);
assertThat(periods.get(1)).describedAs("Wrong periods: %s" + periods)
.isGreaterThanOrEqualTo(1100)
.isLessThanOrEqualTo(1210);
context.close();
}